Enable external needs json & increase versions #1201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The created documentation from the pull request is available at: docu-html |
Increasing docs-as-code version Increasing own module version
| }, | ||
| } | ||
| # This ensures all needs that are imported show up in the build 'needs.json' | ||
| needs_builder_filter = "" |
There was a problem hiding this comment.
this belongs to wherever we have the external need stuff and not into individual conf.py files
There was a problem hiding this comment.
I put it into the conf.py here right now, as this can be done without a complete new release of docs-as-code.
In the next release we should add that in there as a default and figure out a better filter yes.
AlexanderLanin
approved these changes
Jun 6, 2025
40dd375
into
eclipse-score:main
6 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all needs that are external (like process) will be filtered out in the 'needs.json'.
This allows the needs.json to contain ALL of the needs imported.
In a future PR the filter can probably be adapted to make it more efficent, e.g. only get external needs that are actually needed.
##⚠️ This PR should not be merged until new docs-as-code is out. As that has bugfixes that might be imported for here.New docs-as-code version is available. PR can be reviewed and mered.
I pulled the version to a new major one, as the change in needs.json is something that changes how it could be used.
I think that makes sense (at least in my head) .