com: rework Lola Architecture #1133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The created documentation from the pull request is available at: docu-html |
This was referenced May 26, 2025
MarkSchmitt
previously requested changes
May 27, 2025
Comment on lines
49
to
52
| - different bindings which provide the communication functionality (e.g. IPC or SomeIP) | ||
|
|
||
| The abstraction layer is designed in a way to ensure full testability for an end-user, while enabling runtime selection | ||
| of the underlying communication mechanism with the help of different bindings (e.g. IPC, Some-IP ...). |
There was a problem hiding this comment.
Suggested change
| - different bindings which provide the communication functionality (e.g. IPC or SomeIP) | |
| The abstraction layer is designed in a way to ensure full testability for an end-user, while enabling runtime selection | |
| of the underlying communication mechanism with the help of different bindings (e.g. IPC, Some-IP ...). | |
| - different bindings which provide the communication functionality (e.g. IPC or SOME/IP) | |
| The abstraction layer is designed in a way to ensure full testability for an end-user, while enabling runtime selection | |
| of the underlying communication mechanism with the help of different bindings (e.g. IPC, SOME/IP ...). |
| Architecture | ||
| ------------ | ||
|
|
||
| The architecure of communication is diplayed :ref:`here<com_architecture>` |
There was a problem hiding this comment.
Suggested change
| The architecure of communication is diplayed :ref:`here<com_architecture>` | |
| The architecure of communication is displayed :ref:`here<com_architecture>` |
| @@ -0,0 +1,224 @@ | |||
| .. | |||
| # ******************************************************************************* | |||
| # Copyright (c) 2024 Contributors to the Eclipse Foundation | |||
b2cdaba to
9702330
Compare
- Split between communication and IPC - include modules - baselibs - lola
- find review findings - correct interfaces communication uses baselibs
9702330 to
2d07ff5
Compare
LittleHuba
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #937
relates to: #886