-
Notifications
You must be signed in to change notification settings - Fork 4
Fix diffs with different timezones, Date
diffs and #in_years
#5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Date
diffsDate
diffs and #in_years
Hello, @AlexWayfer! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information. |
New fixes added. 😬 |
SourceLevel has finished reviewing this Pull Request and has found:
|
OK, I'll try to fix the offense about class length. |
Please don't. This is not important. I'll tune it down. I just need to set it up properly first. This is just a recommendation. |
OK, as you want (I just love myself to fit into RuboCop standards). Now I see fails in CI for Ruby < 2.7, I need to fix them. |
Add `.ruby-version` to `.gitignore`.
Done, that was easy. |
Sorry, I still see problems in my project with |
No, everything is OK, there was a typo in tests of my project. |
Thank you! I'm glad to use your project and help. |
Add
.ruby-version
to.gitignore
.