+
Skip to content

Conversation

AlexWayfer
Copy link
Contributor

@AlexWayfer AlexWayfer commented Jul 5, 2020

Add .ruby-version to .gitignore.

@AlexWayfer AlexWayfer changed the title Fix different timezones and Date diffs Fix diffs with different timezones, Date diffs and #in_years Jul 7, 2020
@sourcelevel-bot
Copy link

Hello, @AlexWayfer! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

@AlexWayfer
Copy link
Contributor Author

New fixes added. 😬

@sourcelevel-bot
Copy link

SourceLevel has finished reviewing this Pull Request and has found:

  • 1 possible new issue (including those that may have been commented here).

See more details about this review.

@AlexWayfer AlexWayfer marked this pull request as draft July 7, 2020 09:39
@AlexWayfer
Copy link
Contributor Author

OK, I'll try to fix the offense about class length.

@excpt
Copy link
Owner

excpt commented Jul 7, 2020

OK, I'll try to fix the offense about class length.

Please don't. This is not important.

I'll tune it down. I just need to set it up properly first.

This is just a recommendation.

@AlexWayfer
Copy link
Contributor Author

Please don't. This is not important.

OK, as you want (I just love myself to fit into RuboCop standards).

Now I see fails in CI for Ruby < 2.7, I need to fix them.

@AlexWayfer AlexWayfer marked this pull request as ready for review July 7, 2020 09:46
@AlexWayfer
Copy link
Contributor Author

Now I see fails in CI for Ruby < 2.7, I need to fix them.

Done, that was easy.

@AlexWayfer AlexWayfer marked this pull request as draft July 7, 2020 09:52
@AlexWayfer
Copy link
Contributor Author

Sorry, I still see problems in my project with moments usage. I want to re-check all things again.

@AlexWayfer AlexWayfer marked this pull request as ready for review July 7, 2020 09:54
@AlexWayfer
Copy link
Contributor Author

Sorry, I still see problems in my project with moments usage. I want to re-check all things again.

No, everything is OK, there was a typo in tests of my project.

@excpt excpt self-requested a review July 7, 2020 12:34
@excpt excpt merged commit 63a9f81 into excpt:master Jul 7, 2020
@AlexWayfer AlexWayfer deleted the fixes branch July 7, 2020 14:11
@AlexWayfer
Copy link
Contributor Author

Thank you! I'm glad to use your project and help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载