SEAB-6531: Fix some .dockstore.yml inference bugs, reset version #6162
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a couple of bugs in the
.dockstore.yml
inference code:wdl
) to be considered as the primary descriptor of an entry, creating potentially many spurious entries for helper files in the resulting.dockstore.yml
. The root cause was an errant path manipulation that was probably introduced during thePath
conversion. Fixed.It also resets to the
SNAPSHOT
version.Originally, this PR included a tweak that constructed a GitHub ref where a branch name was being used, avoiding some default output and maybe some extra requests. However, the unfixed code seems to [eventually?] do the right thing, and to avoid unintended consequences this late in the deploy cycle, I removed the change.
Review Instructions
Infer a
.dockstore.yml
for github.com/PacificBiosciences/HiFi-human-WGS-WDL and confirm that the inferred.dockstore.yml
contains two entries.Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6531
Security and Privacy
If there are any concerns that require extra attention from the security team, highlight them here and check the box when complete.
e.g. Does this change...
Please make sure that you've checked the following before submitting your pull request. Thanks!
mvn clean install
@RolesAllowed
annotation