+
Skip to content

Conversation

denis-yuen
Copy link
Member

@denis-yuen denis-yuen commented Aug 1, 2025

Description
Try testing a fix for https://security.snyk.io/vuln/SNYK-JAVA-ORGASYNCHTTPCLIENT-8447519
Not sure why it didn't come through dependabot since it is fairly old, could be since it is being used by a Broad dependency.

Review Instructions
Try a few WDL workflow updates and registrations, this may be more sensitive than the average fix since these Broad libraries are fairly old. We don't use or manage cookies, so correctness in function is sufficient for gauging whether the update was successful.

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-7236

Security and Privacy

None

  • Security and Privacy assessed

e.g. Does this change...

  • Any user data we collect, or data location?
  • Access control, authentication or authorization?
  • Encryption features?

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
  • If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
  • Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
  • Do not serve user-uploaded binary images through the Dockstore API
  • Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
  • Do not create cookies, although this may change in the future
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@denis-yuen denis-yuen self-assigned this Aug 1, 2025
Copy link

sonarqubecloud bot commented Aug 1, 2025

Copy link

codecov bot commented Aug 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.20%. Comparing base (d73f427) to head (6f96716).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #6136   +/-   ##
==========================================
  Coverage      74.20%   74.20%           
  Complexity      5664     5664           
==========================================
  Files            389      389           
  Lines          20344    20344           
  Branches        2102     2102           
==========================================
  Hits           15096    15096           
  Misses          4249     4249           
  Partials         999      999           
Flag Coverage Δ
bitbuckettests 25.93% <ø> (ø)
hoverflytests 27.62% <ø> (ø)
integrationtests 56.12% <ø> (ø)
languageparsingtests 10.83% <ø> (ø)
localstacktests 21.33% <ø> (ø)
toolintegrationtests 29.89% <ø> (ø)
unit-tests_and_non-confidential-tests 26.31% <ø> (ø)
workflowintegrationtests 37.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@denis-yuen denis-yuen marked this pull request as ready for review August 5, 2025 14:36
@denis-yuen denis-yuen requested review from a team, kathy-t and svonworl and removed request for a team August 5, 2025 14:37
@denis-yuen denis-yuen merged commit ddad695 into develop Aug 5, 2025
24 checks passed
@denis-yuen denis-yuen deleted the feature/async_http_test branch August 5, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载