+
Skip to content

Conversation

hyunnaye
Copy link
Contributor

@hyunnaye hyunnaye commented Apr 2, 2025

Description
This PR removes restub functionality in the webservice

Review Instructions
Verify tests pass

Issue
https://ucsc-cgl.atlassian.net/browse/DOCK-2585

Security and Privacy

If there are any concerns that require extra attention from the security team, highlight them here and check the box when complete.

  • Security and Privacy assessed

e.g. Does this change...

  • Any user data we collect, or data location?
  • Access control, authentication or authorization?
  • Encryption features?

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
  • If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
  • Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
  • Do not serve user-uploaded binary images through the Dockstore API
  • Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
  • Do not create cookies, although this may change in the future
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

@hyunnaye hyunnaye self-assigned this Apr 2, 2025
Copy link
Member

@denis-yuen denis-yuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in principle, may want to look into test failure

Copy link
Contributor

@kathy-t kathy-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will removing this functionality break any tests in the UI?

@hyunnaye
Copy link
Contributor Author

hyunnaye commented Apr 4, 2025

Will removing this functionality break any tests in the UI?

Yes, so I think merging the UI first will be better. dockstore/dockstore-ui2#2075

Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.18%. Comparing base (e9da120) to head (0bcf7c6).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #6094      +/-   ##
=============================================
- Coverage      74.23%   74.18%   -0.06%     
+ Complexity      5661     5654       -7     
=============================================
  Files            389      389              
  Lines          20341    20319      -22     
  Branches        2103     2098       -5     
=============================================
- Hits           15101    15073      -28     
- Misses          4238     4245       +7     
+ Partials        1002     1001       -1     
Flag Coverage Δ
bitbuckettests 25.95% <ø> (-0.08%) ⬇️
hoverflytests 27.63% <ø> (-0.02%) ⬇️
integrationtests 56.08% <ø> (+<0.01%) ⬆️
languageparsingtests 10.83% <ø> (+0.01%) ⬆️
localstacktests 21.35% <ø> (+0.02%) ⬆️
toolintegrationtests 29.91% <ø> (+0.03%) ⬆️
unit-tests_and_non-confidential-tests 26.31% <ø> (+0.02%) ⬆️
workflowintegrationtests 37.39% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hyunnaye hyunnaye requested review from denis-yuen and kathy-t April 15, 2025 16:45
Copy link

@hyunnaye hyunnaye requested a review from kathy-t April 17, 2025 18:00
@hyunnaye hyunnaye merged commit 1c3f01e into develop Apr 17, 2025
24 checks passed
@hyunnaye hyunnaye deleted the feature/DOCK-2585 branch April 17, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载