-
Notifications
You must be signed in to change notification settings - Fork 29
DOCK-2585: remove restub functionality #6094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in principle, may want to look into test failure
...re-integration-testing/src/test/java/io/dockstore/client/cli/BitBucketGeneralWorkflowIT.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will removing this functionality break any tests in the UI?
Yes, so I think merging the UI first will be better. dockstore/dockstore-ui2#2075 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6094 +/- ##
=============================================
- Coverage 74.23% 74.18% -0.06%
+ Complexity 5661 5654 -7
=============================================
Files 389 389
Lines 20341 20319 -22
Branches 2103 2098 -5
=============================================
- Hits 15101 15073 -28
- Misses 4238 4245 +7
+ Partials 1002 1001 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
...re-integration-testing/src/test/java/io/dockstore/client/cli/BitBucketGeneralWorkflowIT.java
Show resolved
Hide resolved
dockstore-integration-testing/src/test/java/io/dockstore/client/cli/GeneralWorkflowIT.java
Show resolved
Hide resolved
dockstore-integration-testing/src/test/java/io/dockstore/client/cli/GeneralWorkflowIT.java
Show resolved
Hide resolved
dockstore-integration-testing/src/test/java/io/dockstore/webservice/ZenodoIT.java
Outdated
Show resolved
Hide resolved
|
Description
This PR removes restub functionality in the webservice
Review Instructions
Verify tests pass
Issue
https://ucsc-cgl.atlassian.net/browse/DOCK-2585
Security and Privacy
If there are any concerns that require extra attention from the security team, highlight them here and check the box when complete.
e.g. Does this change...
Please make sure that you've checked the following before submitting your pull request. Thanks!
mvn clean install
@RolesAllowed
annotation