+
Skip to content

SEAB-6995: Reenable "authorless" DOIs #6084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2025

Conversation

svonworl
Copy link
Contributor

@svonworl svonworl commented Mar 12, 2025

Description
This PR changes the webservice's DOI generation logic so that it will generate a DOI for a Workflow with no author in the metadata. Essentially, we revert to the pre-1.14 behavior, wherein a filler author is used when no author exists, except that now, we use the Workflow's organization as the filler author's name.

Review Instructions
Create a valid tagged version without an author on a published workflow, and confirm that an automatic DOI is generated, and that the DOI author name matches the workflow's organization.

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-6995

Security and Privacy

If there are any concerns that require extra attention from the security team, highlight them here and check the box when complete.

  • Security and Privacy assessed

e.g. Does this change...

  • Any user data we collect, or data location?
  • Access control, authentication or authorization?
  • Encryption features?

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that you pass the basic style checks and unit tests by running mvn clean install
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • Follow the existing JPA patterns for queries, using named parameters, to avoid SQL injection
  • If you are changing dependencies, check the Snyk status check or the dashboard to ensure you are not introducing new high/critical vulnerabilities
  • Assume that inputs to the API can be malicious, and sanitize and/or check for Denial of Service type values, e.g., massive sizes
  • Do not serve user-uploaded binary images through the Dockstore API
  • Ensure that endpoints that only allow privileged access enforce that with the @RolesAllowed annotation
  • Do not create cookies, although this may change in the future
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.45%. Comparing base (9ca6e75) to head (8b66615).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #6084   +/-   ##
==========================================
  Coverage      74.45%   74.45%           
  Complexity      5639     5639           
==========================================
  Files            386      386           
  Lines          20231    20233    +2     
  Branches        2088     2088           
==========================================
+ Hits           15062    15064    +2     
  Misses          4170     4170           
  Partials         999      999           
Flag Coverage Δ
bitbuckettests 26.13% <0.00%> (-0.01%) ⬇️
hoverflytests 27.72% <0.00%> (-0.01%) ⬇️
integrationtests 55.99% <0.00%> (-0.01%) ⬇️
languageparsingtests 10.85% <0.00%> (-0.01%) ⬇️
localstacktests 21.38% <0.00%> (-0.01%) ⬇️
toolintegrationtests 30.00% <0.00%> (-0.01%) ⬇️
unit-tests_and_non-confidential-tests 26.38% <100.00%> (+<0.01%) ⬆️
workflowintegrationtests 37.65% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@svonworl svonworl requested review from kathy-t, denis-yuen and hyunnaye and removed request for kathy-t March 12, 2025 18:40
Copy link

@svonworl svonworl requested review from denis-yuen and kathy-t March 13, 2025 22:05
@svonworl svonworl merged commit 53769e0 into develop Mar 14, 2025
24 checks passed
@svonworl svonworl deleted the feature/seab-6995/reenable-authorless-dois branch March 14, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载