feat(ListenerHandler): add error handling #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1Computer1
reviewed
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds handling for errors that happen inside listeners.
Changes
Move error event constant from
CommandHandlerEventstoAkairoHandlerEvents;Add
ListenerHandler#emitErrormethod (similar to the CommandHandler counterpart);Add private
ListenerHandler#modifyExecmethod;Add
ListenerHandler#errorevent;Use
modifyExecinregister;Caveats
After deregistering a listener, the modified exec stays on it.Fixed by attaching_rawas the original exec on the modified version with d4032b6 🎉