objects: add BUGFIX for SyncLever #2299
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've known this bug works for a single player where you pull one of the last set as a speedrun strat. You pull one of the final set using telekenesis, town portal back to town, then immediately come back down (or do any shopping if you need something then go back down) and Diablo's cage would be open without having to hit the other one in the set. Never thought about how this would behave with multiple players. I kind of want to check it out in game and see how that looks when the level desyncs like that now. 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When syncing object delta information, special care has to be taken for Skull Levers on dlvl=16, since all levers in a group must be pulled before opening the trigger area (refer to the _oVar8 check of OperateLever). This check is not performed when object delta information is synced, and as such, if a player walks down to dlvl=16 when another player is already on dlvl=16 and has opened one Skull Lever (but not all Skull Levers) of a group, then for the new player entering dlvl=16 (and thus receiving object delta information from the player already present on the level) would have the lever group trigger activated and the map changed, even though all Skull Levers of the given group have not yet been pulled. As such, the map state of these two players will differ considerably.
Edit: furthermore, the
_oVar8check is done for other object delta information sync functions (e.g.SyncCrux).