+
Skip to content

Conversation

gewaleelek
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file at the correct alphabetic position as seen here

This PR closes #434

Link to prove your SVG is correct and up-to-date.

Hyper-V doesn't really have any official icon. The Trademarks PDF in this page doesn't show any icon either. The icon on Wikipedia appears to be unofficial.

The closest I've found is the last screenshot on this page, which I've used as the main reference for this icon. The font is Segoe UI Regular with manual kerning.

image

Copy link
Contributor

github-actions bot commented Mar 7, 2025

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@canaleal canaleal added the feature:icon PR when a new icon is ready to be added to the collection label Mar 10, 2025
weh
weh previously approved these changes Mar 12, 2025
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@weh weh requested review from a team, ConX, Snailedlt, canaleal and lunatic-fox and removed request for a team March 12, 2025 12:50
@Snailedlt
Copy link
Collaborator

Microsoft is notoriously bad at making consistent official logos.

It seems to me like some variation of this image could be considered the logo:
https://en.wikipedia.org/wiki/Hyper-V#/media/File:Hyper-V_icon.png
image

It's many places in the program itself as well as the .exe shortcut image
image

The icon found on wikipedia seems like the closest thing to me, based on what's used in and around the application itself.

Perhaps the icon I suggested can be added as the original, and the one you made as the wordmark?
Either way it's hard to work with when there is no one single official logo to go off of

@weh @canaleal @lunatic-fox @gewaleelek what do you guys think?

@gewaleelek
Copy link
Contributor Author

gewaleelek commented Mar 12, 2025

That does seem official enough to me; I didn't have the means to check the actual thing myself, and thought the Wikipedia one was unofficial since the source URL is some unofficial forums. I can probably submit new icons tomorrow.

For the wordmark, should it be:

  • HyperV text alone, or
  • That server icon + HyperV text (I think they're rarely seen together but we usually use icon+text for wordmarks right?)

@Snailedlt
Copy link
Collaborator

Inrealized Hyper-V was preinstslled on my PC, otherwise I wouldn't have bothered checking, so I just got luckt I guess 😅

I'm not sure what's best for the wordmark version. Both are fine by me, so choose whatever you think is best

Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@gewaleelek
Copy link
Contributor Author

I've added the new icons.

Add empty newline
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the new icons, and added a newline 👍

Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@canaleal canaleal merged commit 44246cd into devicons:develop Mar 30, 2025
5 checks passed
@gewaleelek gewaleelek deleted the hyperv branch April 4, 2025 08:27
@canaleal canaleal mentioned this pull request Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon PR when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载