-
Notifications
You must be signed in to change notification settings - Fork 2.4k
new icon: hyperv (original) #2381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi! I'm the
Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
Microsoft is notoriously bad at making consistent official logos. It seems to me like some variation of this image could be considered the logo: It's many places in the program itself as well as the .exe shortcut image The icon found on wikipedia seems like the closest thing to me, based on what's used in and around the application itself. Perhaps the icon I suggested can be added as the original, and the one you made as the wordmark? @weh @canaleal @lunatic-fox @gewaleelek what do you guys think? |
That does seem official enough to me; I didn't have the means to check the actual thing myself, and thought the Wikipedia one was unofficial since the source URL is some unofficial forums. I can probably submit new icons tomorrow. For the wordmark, should it be:
|
Inrealized Hyper-V was preinstslled on my PC, otherwise I wouldn't have bothered checking, so I just got luckt I guess 😅 I'm not sure what's best for the wordmark version. Both are fine by me, so choose whatever you think is best |
Hi! I'm the
Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
I've added the new icons. |
Add empty newline
Hi! I'm the
Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked the new icons, and added a newline 👍
Hi! I'm the
Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
Double check these details before you open a PR
develop
branch.devicon.json
file at the correct alphabetic position as seen hereThis PR closes #434
Link to prove your SVG is correct and up-to-date.
Hyper-V doesn't really have any official icon. The Trademarks PDF in this page doesn't show any icon either. The icon on Wikipedia appears to be unofficial.
The closest I've found is the last screenshot on this page, which I've used as the main reference for this icon. The font is Segoe UI Regular with manual kerning.