apps/web/app/(ee)/partners.dub.co/(dashboard)/programs/[programSlug]/(enrolled)/links/partner-link-card.tsx (2)

186-196: Guard against undefined program slug in chart tile href.

If programEnrollment hasn’t loaded, href becomes /programs/undefined/analytics.... Gate rendering or provide a non-navigable fallback until slug is present.

Example approach: compute const slug = programEnrollment?.program.slug; and render a <div> with the same content (no onClick) when !slug, otherwise render the <Link>.

---

100-105: Normalize currency units (avoid mixing cents vs. dollars).

Chart series data converts saleAmount to dollars, while totals keep cents and divide at render. Keep a single unit (e.g., cents) in data and convert only at display to reduce cognitive overhead.

-  const chartData = useMemo(() => {
-    return timeseries?.map(({ start, clicks, leads, saleAmount }) => ({
-      date: new Date(start),
-      values: { clicks, leads, saleAmount: saleAmount / 100 },
-    }));
-  }, [timeseries]);
+  const chartData = useMemo(() => {
+    return timeseries?.map(({ start, clicks, leads, saleAmount }) => ({
+      date: new Date(start),
+      values: { clicks, leads, saleAmount }, // keep cents
+    }));
+  }, [timeseries]);

-                  {currency ? (
-                    <NumberFlow
-                      value={series.valueAccessor(d)}
-                      format={{ style: "currency", currency: "USD" }}
-                    />
-                  ) : (
+                  {currency ? (
+                    <NumberFlow
+                      value={series.valueAccessor(d) / 100}
+                      format={{ style: "currency", currency: "USD" }}
+                    />
+                  ) : (
                     <NumberFlow value={series.valueAccessor(d)} />
                   )}

Also applies to: 306-314

apps/web/app/(ee)/partners.dub.co/(dashboard)/messages/[programSlug]/page-client.tsx (3)

59-72: Harden mark-as-read side-effect

Wrap in try/catch and bail early if no unread or already pending to avoid noisy errors and unnecessary revalidations.

-      onSuccess: async (data) => {
-        // Mark unread messages from the program as read
-        if (
-          !isMarkingProgramMessagesRead &&
-          data?.[0]?.messages?.some(
-            (message) => !message.senderPartnerId && !message.readInApp,
-          )
-        ) {
-          await markProgramMessagesRead({
-            programSlug,
-          });
-          mutatePrefix("/api/partner-profile/messages");
-        }
-      },
+      onSuccess: async (data) => {
+        const hasUnread =
+          data?.[0]?.messages?.some(
+            (m) => !m.senderPartnerId && !m.readInApp,
+          ) ?? false;
+        if (isMarkingProgramMessagesRead || !hasUnread) return;
+        try {
+          await markProgramMessagesRead({ programSlug });
+          mutatePrefix("/api/partner-profile/messages");
+        } catch (err) {
+          console.error("Failed to mark messages as read", err);
+        }
+      },

---

233-240: Prevent reverse‑tabnabbing with window.open

Pass noopener,noreferrer to window.open for safety.

-                onClick={() =>
-                  window.open(`/programs/${programSlug}`, "_blank")
-                }
+                onClick={() =>
+                  window.open(
+                    `/programs/${programSlug}`,
+                    "_blank",
+                    "noopener,noreferrer",
+                  )
+                }

---

355-379: Disable “Copy link” when no partner link available

Avoid copying an empty string and improve UX with a title.

-        <Button
+        <Button
           icon={
             <div className="relative size-4">
@@
           }
           text={copied ? "Copied link" : "Copy link"}
           className="mt-3 h-8 rounded-lg"
-          onClick={() => copyToClipboard(partnerLink)}
+          disabled={!partnerLink}
+          title={partnerLink ? "Copy referral link" : "No referral link available"}
+          onClick={() => partnerLink && copyToClipboard(partnerLink)}
         />

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

packages/prisma/schema/notification.prisma (5)

13-13: Avoid losing audit trail: prefer onDelete: SetNull over Cascade.

If a Message is deleted, you likely still want to retain the email event. Since messageId is nullable, SetNull fits.

-  message Message? @relation(fields: [messageId], references: [id], onDelete: Cascade)
+  message Message? @relation(fields: [messageId], references: [id], onDelete: SetNull)

---

1-3: If only “Message” emails exist, make messageId required.

With a single enum variant (Message), letting messageId be null introduces invalid states. If more types are planned, ignore.

 enum NotificationEmailType {
   Message
 }
 
 model NotificationEmail {
   id        String                @id @default(cuid())
   emailId   String // Resend email id
-  messageId String?
+  messageId String
   type      NotificationEmailType
   openedAt  DateTime?
   createdAt DateTime              @default(now())
 
-  message Message? @relation(fields: [messageId], references: [id], onDelete: Cascade)
+  message Message  @relation(fields: [messageId], references: [id], onDelete: Restrict)

Run this only if all records are tied to a Message. Otherwise keep nullable + SetNull as in the prior comment.

Also applies to: 8-8, 13-13

---

10-11: Add indexes for cron scans and retention queries.

If you query “unopened” or time windows, dedicated indexes help. Composite on (emailId, openedAt) doesn’t cover “openedAt IS NULL” scans efficiently.

   openedAt  DateTime?
   createdAt DateTime              @default(now())

   @@index([emailId, openedAt])
+  @@index([openedAt])
+  @@index([createdAt])
   @@index(type)
   @@index(messageId)

Also applies to: 15-18

---

11-11: Consider updatedAt for debugging/audit.

Handy for webhook updates and ops visibility.

-  createdAt DateTime              @default(now())
+  createdAt DateTime              @default(now())
+  updatedAt DateTime              @updatedAt

---

1-3: Index on type is currently low-value.

With a single enum variant, this index won’t filter. Keep if you’ll add variants soon; otherwise drop to reduce index bloat.

-  @@index(type)

Also applies to: 16-16

apps/web/ui/layout/sidebar/partners-sidebar-nav.tsx (4)

74-81: Badge logic: show “9+” and avoid treating 0 as truthy.

Current ternary hides 0 (good) but caps to 9 without “+”. Suggest explicit “9+” for clarity and stricter number check.

Apply:

-    badge: unreadMessagesCount ? Math.min(9, unreadMessagesCount) : undefined,
+    badge:
+      typeof unreadMessagesCount === "number" && unreadMessagesCount > 0
+        ? unreadMessagesCount > 9
+          ? "9+"
+          : unreadMessagesCount
+        : undefined,

---

142-149: Program‑level Messages entry looks right.

Arrow affordance makes sense for a thread view. Consider adding a program‑scoped unread badge when available in future.

---

174-195: “Bounties” badge shows “New” when count is 0.

The current truthy check maps 0 to “New”, which is misleading. Prefer undefined for 0.

Apply:

-            badge: programBountiesCount
-              ? programBountiesCount > 99
-                ? "99+"
-                : programBountiesCount
-              : "New",
+            badge:
+              typeof programBountiesCount === "number"
+                ? programBountiesCount > 99
+                  ? "99+"
+                  : programBountiesCount > 0
+                    ? programBountiesCount
+                    : undefined
+                : "New",

---

327-333: Pass query values as strings to match URLSearchParams and reduce TS casts.

Minor type‑hygiene tweak; behavior unchanged.

Apply:

-  const { count: unreadMessagesCount } = useProgramMessagesCount({
-    enabled: true,
-    query: {
-      unread: true,
-    },
-  });
+  const { count: unreadMessagesCount } = useProgramMessagesCount({
+    enabled: true,
+    query: { unread: "true" },
+  });

Optionally consider SWR opts (e.g., revalidateOnFocus: false) if badge flicker is observed.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Learnt from: devkiran
PR: dubinc/dub#2448
File: packages/email/src/templates/partner-program-summary.tsx:0-0
Timestamp: 2025-05-29T04:45:18.504Z
Learning: In the PartnerProgramSummary email template (packages/email/src/templates/partner-program-summary.tsx), the stat titles are hardcoded constants ("Clicks", "Leads", "Sales", "Earnings") that will always match the ICONS object keys after toLowerCase() conversion, so icon lookup failures are not possible.

apps/web/app/(ee)/partners.dub.co/(dashboard)/messages/[programSlug]/page-client.tsx (1)

156-167: Guard optimistic updates when SWR data is empty to prevent crashes

Accessing data[0] when data is [] throws. Use optional chaining and preserve the previous cache if empty. Applies to both mutate updater and optimisticData.

-                    return data
-                      ? [
+                    return data?.[0]
+                      ? [
                           {
                             ...data[0],
                             messages: [
                               ...data[0].messages,
                               result.data.message,
                             ],
                           },
-                        ]
-                      : [];
+                        ]
+                      : data ?? [];
@@
-                    optimisticData: (data) =>
-                      data
-                        ? [
+                    optimisticData: (data) =>
+                      data?.[0]
+                        ? [
                             {
                               ...data[0],
                               messages: [
                                 ...data[0].messages,
                                 {
                                   delivered: false,
                                   id: `tmp_${uuid()}`,
                                   programId: program!.id,
                                   partnerId: partner!.id,
                                   text: message,
@@
                                 },
                               ],
                             },
-                          ]
-                        : [],
+                          ]
+                        : data ?? [],

Also applies to: 169-206

apps/web/app/(ee)/partners.dub.co/(dashboard)/messages/[programSlug]/page-client.tsx (4)

139-146: Defensive guard: avoid non-null assertions in onSendMessage

onSendMessage uses program!/partner!/user!. Add a quick guard to avoid runtime errors if a user manages to send before data is ready.

-            onSendMessage={async (message) => {
-              const createdAt = new Date();
+            onSendMessage={async (message) => {
+              if (!program || !partner || !user) {
+                toast.error("Still loading, please try again.");
+                return;
+              }
+              const createdAt = new Date();

---

169-206: Reduce redundant network traffic after optimistic send

You already call mutatePrefix after success. Disable auto revalidate here to avoid double fetches.

                     rollbackOnError: true,
+                    revalidate: false,

---

316-319: Encode fallback avatar URL to handle spaces/unicode

Avoid broken images for program names with spaces/special chars.

-            src={program.logo || `${OG_AVATAR_URL}${program.name}`}
+            src={program.logo || `${OG_AVATAR_URL}${encodeURIComponent(program.name)}`}

---

347-353: UX: disable “Copy link” when no referral link exists

Prevents copying an empty string and clarifies state.

-        <input
+        <input
           type="text"
           readOnly
           value={getPrettyUrl(partnerLink)}
           className="border-border-default text-content-default focus:border-border-emphasis bg-bg-default mt-2 block h-10 w-full rounded-md border px-3 text-sm focus:outline-none focus:ring-neutral-500"
         />
@@
-        <Button
+        <Button
+          disabled={!partnerLink}
           icon={
@@
-          onClick={() => copyToClipboard(partnerLink)}
+          onClick={() => partnerLink && copyToClipboard(partnerLink)}
         />

Also applies to: 354-378

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

apps/web/ui/messages/messages-panel.tsx (1)

1-1: Add "use client" at the top.

This file uses hooks and navigator; without the directive it will error in Next.js.

+"use client";
+
 import { Message } from "@/lib/types";

apps/web/ui/messages/messages-panel.tsx (7)

41-47: Don’t block sending when messages array is undefined.

Preventing sends until messages are loaded is unnecessary.

-  const sendMessage = () => {
-    if (!messages || !typedMessage.trim()) return;
+  const sendMessage = () => {
+    if (!typedMessage.trim()) return;
 
     onSendMessage(typedMessage.trim());
     setTypedMessage("");
     scrollRef.current?.scrollTo({ top: 0 });
   };

---

245-261: Disable Send when input is empty.

Avoids no-op click and matches keyboard guard.

 <Button
   variant="primary"
   text={
@@
   }
   onClick={sendMessage}
+  disabled={!typedMessage.trim()}
   className="h-8 w-fit rounded-lg px-4"
 />

---

250-252: Guard navigator access.

Small SSR-safety improvement even with client directive.

-                      {navigator.platform.startsWith("Mac") ? "⌘" : "^"}
+                      {typeof navigator !== "undefined" && navigator.platform.startsWith("Mac") ? "⌘" : "^"}

---

123-141: Disable tooltip when sender name is missing.

Prevents empty tooltip content.

-                    <Tooltip content={sender?.name}>
+                    <Tooltip content={sender?.name} disabled={!sender?.name}>

---

125-132: Harden avatar src/alt; encode name and add lazy loading.

Prevents “undefined” URLs and improves perf.

-                        <img
-                          src={
-                            sender?.image || `${OG_AVATAR_URL}${sender?.name}`
-                          }
-                          alt={`${sender?.name} avatar`}
-                          className="size-8 rounded-full"
-                          draggable={false}
-                        />
+                        <img
+                          src={
+                            sender?.image ??
+                            (sender?.name
+                              ? `${OG_AVATAR_URL}${encodeURIComponent(sender.name)}`
+                              : `${OG_AVATAR_URL}User`)
+                          }
+                          alt={`${sender?.name ?? "User"} avatar`}
+                          loading="lazy"
+                          className="size-8 rounded-full"
+                          draggable={false}
+                        />

---

71-71: Minor: drop optional chaining in map.

Inside the truthy branch, messages is defined.

-            {messages?.map((message, idx) => {
+            {messages.map((message, idx) => {

---

233-241: Maintain caret after emoji insert.

Improves UX for consecutive emoji inserts.

-              <EmojiPicker
-                onSelect={(emoji) => {
-                  const pos = selectionStartRef.current;
-                  setTypedMessage((prev) =>
-                    pos !== null
-                      ? prev.slice(0, pos) + emoji + prev.slice(pos)
-                      : prev + emoji,
-                  );
-                  textAreaRef.current?.focus();
-                }}
-              />
+              <EmojiPicker
+                onSelect={(emoji) => {
+                  const pos = selectionStartRef.current;
+                  setTypedMessage((prev) => {
+                    const start = pos ?? prev.length;
+                    const next = prev.slice(0, start) + emoji + prev.slice(start);
+                    requestAnimationFrame(() => {
+                      const el = textAreaRef.current;
+                      if (el) {
+                        const caret = start + emoji.length;
+                        el.setSelectionRange(caret, caret);
+                        selectionStartRef.current = caret;
+                      }
+                    });
+                    return next;
+                  });
+                  textAreaRef.current?.focus();
+                }}
+              />

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro