Workspace onboarding improvements #2679
Conversation
Grouped a couple of changes here: - Updated the workspace language to cut down on the word usage of workspace - Added the back to sign in button to show only on the onboarding/workspace page
|
@marcusljf is attempting to deploy a commit to the Dub Team on Vercel. A member of the Team first needs to authorize it. |
|
Warning Rate limit exceeded@steven-tey has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 5 minutes and 42 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
WalkthroughThe updates consist of UI text changes and a conditional button addition. The onboarding layout now runs in client mode, displays a "Sign in as a different user" button on the workspace onboarding page that triggers sign out and redirects to login. Minor label and description text adjustments were made in the onboarding step and workspace form components. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant OnboardingLayout
participant Auth
User->>OnboardingLayout: Visit /onboarding/workspace
OnboardingLayout->>OnboardingLayout: Render "Sign in as a different user" button with user email
User->>OnboardingLayout: Click "Sign in as a different user"
OnboardingLayout->>Auth: signOut(callbackUrl="/login")
Auth->>User: Redirect to /login
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Suggested reviewers
Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/web/app/app.dub.co/(onboarding)/layout.tsx (1)
17-33: Fix redundant button text declaration.The button implementation is solid, but you're declaring the text twice - once in the
textprop and once as children.<Button variant="secondary" - text="Back to sign in" size="sm" onClick={() => signOut({ callbackUrl: "/login", }) } className="h-8 text-xs rounded-lg px-3 shadow-sm" > Back to sign in </Button>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
apps/web/app/app.dub.co/(onboarding)/layout.tsx(1 hunks)apps/web/app/app.dub.co/(onboarding)/onboarding/(steps)/workspace/page.tsx(1 hunks)apps/web/ui/workspaces/create-workspace-form.tsx(2 hunks)
🧰 Additional context used
🧠 Learnings (1)
apps/web/app/app.dub.co/(onboarding)/layout.tsx (1)
Learnt from: TWilson023
PR: #2484
File: apps/web/app/app.dub.co/(onboarding)/onboarding/(steps)/layout.tsx:9-44
Timestamp: 2025-06-25T18:07:53.860Z
Learning: In the dub codebase onboarding layouts, avoid suggesting premature abstraction of shared background components when the implementations are still dynamic and might diverge. The team prefers to wait until patterns stabilize before creating shared components.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
🔇 Additional comments (6)
apps/web/app/app.dub.co/(onboarding)/onboarding/(steps)/workspace/page.tsx (1)
10-10: LGTM! Improved terminology for better user understanding.The change from "common space" to "shared space" is more intuitive and user-friendly, making the workspace concept clearer to new users.
apps/web/ui/workspaces/create-workspace-form.tsx (2)
141-141: LGTM! Cleaner label without redundant context.Removing "Workspace" from "Workspace Slug" makes sense since users are already in the workspace creation context.
207-207: LGTM! Simplified label improves readability.Shortening "Workspace Logo" to "Logo" reduces redundancy and creates a cleaner interface.
apps/web/app/app.dub.co/(onboarding)/layout.tsx (3)
1-1: LGTM! Client directive necessary for hooks and event handlers.The "use client" directive is required for the usePathname hook and onClick handler.
5-7: LGTM! Appropriate imports for the new functionality.All imports are necessary for the conditional button implementation.
10-11: LGTM! Clean pathname-based conditional logic.The pathname check correctly targets the workspace onboarding page.
Enhanced the onboarding workspace layout to show the signed-in user's email and improved the sign-out button with loading state and updated text. Updated labels in the create workspace form for clarity and consistency.
Summary by CodeRabbit
New Features
Style