+
Skip to content

Conversation

lprat
Copy link

@lprat lprat commented Sep 21, 2017

  • Fixed bug on indictor add by dataminer
  • Fixed bug on indicator update (problem with object user and string user.username)
  • Fixed bug to add object in indicator (need tlp information to add and problem with user.username)

Thanks!
Lionel

@lprat
Copy link
Author

lprat commented Sep 21, 2017

add: Fix bug in parse ole date email and user.username relationship

@mgoffin
Copy link
Contributor

mgoffin commented Sep 27, 2017

Debating whether we want to still allowing uploading if creation of the ISODATE fails. Thoughts?

@lprat
Copy link
Author

lprat commented Sep 27, 2017

You have right. In my first patch, i was not understand than the problem came of olefile. The real problem is 0x00 add by olefile on header email, byte null prevent to parse header (look at e7be1b9).
I changed return if isodate fails: ebfb025

@mgoffin
Copy link
Contributor

mgoffin commented Oct 6, 2017

You are adding a lot of stuff to this. I think it would be best if this PR focused on the original specific issue. Adding new Indicator vocabulary is usually an issue submitted with a request to add it and what it would be used for to ensure it's unique and not already provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载