Record User for TLO Creation/Modification & Status Modification #906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm fine adding exposure of both created and last modified dates and times to this PR. It seems essential to see both if you are trying to reference who and when! |
|
Okay cool. The last items in the table for most TLOs are (in order): Status, Sectors, Sources (where applicable), Releasability. What do you think about making every TLO's summary table end with: Created |
|
Seems consistent! |
|
Okay! All TLOs should now display Created and Modified timestamps. I changed the order slightly (moved Sectors before Created) because it looked better in a few cases. The code and presentation is more consistent now. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it is not always clear which user created a particular TLO and who last modified a TLO.
Additionally, from a workflow perspective, it is important to know who last modified a TLO's status field.
This change sets a few new values in the database to record this information for all TLOs. Because these are new fields, no migration is necessary.
While implementing this, I realized that the display of creation/modification timestamps on TLO detail pages is very inconsistent. Some show both, while others show just one or neither. This PR does not change which TLOs display those values, but I think it might be valuable to discuss making this consistent across all TLOs.
I'm open to feedback. Let me know if you notice that I missed something!