Better error handling of mountArtifact

Currently when cri-o fails to mount artifacts, it always fallback to mount images, but there're some cases that we don't have to fallback.

https://github.com/cri-o/cri-o/blob/fd5db98e6deba92764303934b22f6c01bbb257e1/server/container_create_linux.go#L211-L235

This issue intends to figure out what errors are fallback-able, and avoid fallback in other cases.

	if m.GetImage().GetImage() != "" {
	if s.config.OCIArtifactMountSupport {
	// Try mountArtifact first, and fall back to mountImage if it fails with ErrNotFound
	artifactVolumes, err := s.mountArtifact(ctx, specgen, m, mountLabel, skipRelabel, maybeRelabel)
	if err == nil {
	volumes = append(volumes, artifactVolumes...)

	continue
	}
	} else {
	log.Debugf(ctx, "Skipping artifact mount because OCI artifact mount support is disabled")
	}

	log.Warnf(ctx, "Artifact mount failed with %s. Falling back to image mount", err)

	volume, safeMount, err := s.mountImage(ctx, specgen, imageVolumesPath, m, runDir)
	if err != nil {
	return nil, nil, nil, fmt.Errorf("%w: %w", crierrors.ErrImageVolumeMountFailed, err)
	}

	volumes = append(volumes, *volume)
	safeMounts = append(safeMounts, safeMount)

	continue
	}

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Better error handling of mountArtifact #9165

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Better error handling of mountArtifact #9165

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions