Meet OSM tile server policy requirements #7302
Conversation
|
I tested with the (rebased) branch of https://github.com/deltachat/deltachat-desktop/tree/maps-with-own-session and can confirm that this PR solves the problem of being blocked on openstreetmap.org. So it was obviously the missing User-Agent that caused the problem.
At least for the tested map services in https://github.com/deltachat/maps/pull/6/files#diff-a333452cdd596c6103364e45efcd5bb8539164522389793fbc524cb74e27b625 I can confirm that only openstreetmap.org was blocked by the missing user agent |
1a0b709 to
8e67682
Compare
37d31e1 to
1744d0c
Compare
|
This should be good enough for now. One problem is that |
There was a problem hiding this comment.
I tested this again with deltachat/deltachat-desktop#5455 and it works as expected
1744d0c to
99dc568
Compare
99dc568 to
2b4195b
Compare
This PR is for experiments in Desktop trying to route map requests over the core.
OpenStreetMap requires User-Agent to be set: https://operations.osmfoundation.org/policies/api/
Don't know if
hypersends anything at all when noUser-Agentis set. OSM explicitly says that User-Agent should not be faked. We however don't want to send "chatmail" User-Agent in requests for images in HTML emails, so if this works we may need a switch to not fake the user agent for map requests and by default fake some browser User-Agent for privacy.We may also just hardcode a domain name for which we send User-Agent, this will require no API changes at all.