test: Add unique offsets to ids generated by TestContext to increase test correctness
#7297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
correctness of tests. The ids that get offsets are: contact ids chat ids message ids webxdc status update ids
|
Seems my approach of just dividing the random number does not work, this approach is not compatible with the golden tests: we could add an id to the named accounts, as this offset needs to be unique account per per test, but not unique across all tests. |
TestContext to increaseTestContext to increase test correctness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and fix the mistakes in tests that get discovered by this.
closes #6799