Limit cases when contact's status and avatar are updated (#7002) #7123
+108
−152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3e0a181 to
13ee0d1
Compare
13ee0d1 to
137ede8
Compare
Simon-Laux
reviewed
Oct 9, 2025
…sent This prepares for sending self-status only together with self-avatar in encrypted messages. The idea is that self-status normally doesn't change frequently, so it's not a problem to re-send the whole profile. Self-status is rather a biography, it even goes to "NOTE:" in vCards, so it's not a contact status at a particular moment like "online" or "busy", and to see it one should go to the contact profile. Don't check for "Chat-Version" header though. So if a non- Delta Chat key-contact removes footer, its "status" remains, but this shouldn't be a problem. For unencrypted messages self-status will still be always attached except MDNs, reactions and SecureJoin messages, so that it's visible as the message footer in other MUAs.
The normal way of synchronizing self-avatar and -status nowadays is sync messages.
137ede8 to
aafa034
Compare
Simon-Laux
reviewed
Oct 12, 2025
| Config::Selfstatus => { | ||
| // Currently we send the self-status in every appropriate message, but in the future | ||
| // we want to send it periodically together with the self-avatar. This ensures the | ||
| // correct behavior after a possible upgrade. |
There was a problem hiding this comment.
upgrade of what? delta chat or the self status?
Simon-Laux
reviewed
Oct 12, 2025
Comment on lines
+748
to
+749
| // Currently we send the self-status in every appropriate message, but in the future | ||
| // we want to send it periodically together with the self-avatar. This ensures the |
There was a problem hiding this comment.
"in the future", what does this mean? when this pr is merged or somewhere else?
I'm still confused 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both commits here may fix #7002. If that doesn't happen, we'll reopen it.