+
Skip to content

feat(jsonrpc): new property chat_type in ChatListItem #7003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 14, 2025
Merged

Conversation

nicodh
Copy link
Contributor

@nicodh nicodh commented Jul 14, 2025

api!(jsonrpc): removed ChatListItem.is_broadcast

api(jsonrpc): mark ChatListItem.is_group as deprecated

api!(jsonrpc): removed ChatListItem.is_broadcast

api(jsonrpc): mark ChatListItem.is_group as deprecated
@nicodh nicodh requested review from Hocuri, WofWca and r10s July 14, 2025 07:02
@nicodh
Copy link
Contributor Author

nicodh commented Jul 14, 2025

As discussed with Hocuri.

There is still no property to check, if a user left a channel or not. That's why we always show "Leave channel" even if the user already left it.

This means also, that a user can not reenter the channel, which is something to be fixed in future imo. Setting the remove_timestamp in chats_contacts when leaving a channel could fix that.

Copy link
Collaborator

@WofWca WofWca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is tidier.

Note that this is breaking.

@Hocuri
Copy link
Collaborator

Hocuri commented Jul 14, 2025

api!(jsonrpc): removed ChatListItem.is_broadcast

api(jsonrpc): mark ChatListItem.is_group as deprecated

Note that these won't show up in the changelog if they are not in the title of a commit. Easiest solution is to squash merge and just call the commit api!: In ChatListItem, replace is_group and is_(out_)broadcast with chat_type property; I think this is specific enough, no need to say what is deprecated and what removed. Alternatively, you can prefix with BREAKING CHANGE as explained in https://github.com/chatmail/core/blob/main/CONTRIBUTING.md, or break it up into multiple commits which you rebase-merge.

@nicodh nicodh merged commit 0142515 into main Jul 14, 2025
29 checks passed
@nicodh nicodh deleted the add-chat-type branch July 14, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载