feat: Synchronize encrypted groups creation across devices (#7001) #7009
Conversation
af4c33a to
2530a6c
Compare
2530a6c to
e4fd633
Compare
e4fd633 to
fa5fda4
Compare
|
Thanks for fixing! Once member addition&removal works, this LGTM |
ab25c68 to
55bb249
Compare
55bb249 to
7904843
Compare
7904843 to
0fa0f14
Compare
There was a problem hiding this comment.
Nice!
But @link2xt said in #7111 (comment) to merge the PR here after #7116, so, merging this still has to wait a bit.
|
It's after #7116 not because of merge conflict, but because if we do this before removing protected groups, we need to synchronize whether the group is protected or not. So we first remove protected groups and then don't have to synchronize this status. |
0fa0f14 to
be8d47a
Compare
5051240 to
f1121da
Compare
be8d47a to
4ad5eeb
Compare
Unencrypted groups don't have grpid since key-contacts were merged, so we don't sync them for now.
If we use modules (which are actually namespaces), we can use shorter names. Another approach is to only use modules for internal code incapsulation and use full names like deltachat-ffi does.
f1121da to
f6c2ada
Compare
4ad5eeb to
ebea50e
Compare
| let fingerprint = row.get(0)?; | ||
| let addr = row.get(1)?; | ||
| if row.get::<_, ContactId>(0)? == ContactId::SELF { | ||
| return Ok((self_fp.to_string(), String::new())); |
There was a problem hiding this comment.
What is this change for?
(I may not have all context for this pr in my head, just trying to understand how it works.)
There was a problem hiding this comment.
There's no fingerprint for the self-contact in the contacts table, so we need to handle this case separately. AFAIR some test is failing w/o syncing the self-contact if it's actually in the chat
Fix #7001
To be merged after #7116