feat: Log failed debug assertions in all configurations #6996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `logged_debug_assert` macro logging a warning if a condition is not satisfied, before invoking `debug_assert!`, and use this macro where `Context` is accessible (i.e. don't change function signatures for now). Follow-up to 0359481.
link2xt
reviewed
Jul 12, 2025
| #[macro_export] | ||
| macro_rules! logged_debug_assert { | ||
| ($ctx:expr, $cond:expr, $($arg:tt)*) => { | ||
| if !$cond { |
There was a problem hiding this comment.
Would be nice to assign $cond to a local variable to avoid evaluating the expression twice. Same for other macros.
There was a problem hiding this comment.
The only other one is ensure_and_debug_assert. But i wanted to pass $cond to debug_assert as is so that it prints a nicer assertion failed: <stringified expr> line. Maybe it's not that important and we indeed should assign the value to a local var. Anyway one needs to look into the source code usually to debug it.
There was a problem hiding this comment.
Done in #7004. It prints informative messages also
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
logged_debug_assertmacro logging a warning if a condition is not satisfied, before invokingdebug_assert!, and use this macro whereContextis accessible (i.e. don't change function signatures for now).Follow-up to 0359481.