feat: experimental header protection for Autocrypt #6173
Conversation
e59a970 to
f317a5a
Compare
c70f0ed to
08f97a4
Compare
|
Enabling this by default breaks only 2 Rust tests (which expect to see Autocrypt header in unprotected part) and 1 Python test (which expects that Autocrypt header is visible on undecipherable message so reply is encrypted). So once sufficient number of clients support header protection we can easily enable it for Autocrypt. |
08f97a4 to
60f5387
Compare
| alice | ||
| .set_config_bool(Config::ProtectAutocrypt, true) | ||
| .await?; | ||
| bob.set_config_bool(Config::ProtectAutocrypt, true).await?; |
There was a problem hiding this comment.
Seems rustfmt has weird default setting, 67 chars are ok, but 69 are already wrapped. I think at least 80 never need wrapping
There was a problem hiding this comment.
It's https://rust-lang.github.io/rustfmt/?version=v1.6.0&search=#chain_width (60 w/o indentation). Also see https://rust-lang.github.io/rustfmt/?version=v1.6.0&search=#use_small_heuristics for other defaults. I'd suggest to set the limit for all statements to 80 chars, that was always fine as far as i remember
There was a problem hiding this comment.
Changing rustfmt settings will break git blame and outstanding PRs, and likely make some other lines look worse than before. These two lines look odd next to each because they are formatted differently, but not worth the trouble of reformatting the whole codebase and tweaking settings.
Just changing chain_width to 100 generated warnings and a diff with "90 files changed, 1640 insertions(+), 4645 deletions(-)".
There was a problem hiding this comment.
Yes, this isn't an option. Unfortunately there's no option to preserve already existing line breaks :/
This change adds support for receiving Autocrypt header in the protected part of encrypted message. Autocrypt header is now also allowed in mailing lists. Previously Autocrypt header was rejected when List-Post header was present, but the check for the address being equal to the From: address is sufficient. New experimental `protect_autocrypt` config is disabled by default because Delta Chat with reception support should be released first on all platforms.
60f5387 to
7055c2d
Compare
This change adds support for receiving
Autocrypt header in the protected part of encrypted message.
Autocrypt header is now also allowed in mailing lists.
Previously Autocrypt header was rejected when
List-Post header was present,
but the check for the address being equal to the From: address
is sufficient.
New experimental
protect_autocryptconfig is disabledby default because Delta Chat with reception
support should be released first on all platforms.
Closes #6171