+
Skip to content

feat(html): add experimental-html feature flag to enable html file handler #3967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2024
Merged

feat(html): add experimental-html feature flag to enable html file handler #3967

merged 1 commit into from
Sep 19, 2024

Conversation

dyc3
Copy link
Contributor

@dyc3 dyc3 commented Sep 18, 2024

Summary

This PR reenables the HTML file handler, but only when compiled with the experimental-html flag.

Test Plan

Tested it manually on one of my projects. Shouldn't cause problems in ecosystem ci.

@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project labels Sep 18, 2024
@dyc3 dyc3 force-pushed the html-feature-flag branch from 18742af to 2c353c9 Compare September 18, 2024 11:55
ematipico
ematipico reviewed Sep 18, 2024
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must add this feature to biome_wasm as well, so we can compile the playground WASM module with that. This means this step of the workflow must be compiled with the new feature

biome/.github/workflows/repository_dispatch.yml

Line 42 in 2c8ff7f

run: wasm-pack build --out-dir ../../packages/@biomejs/wasm-web --target web --profiling --scope biomejs crates/biome_wasm

@dyc3 dyc3 force-pushed the html-feature-flag branch from 2c353c9 to 00b9fdf Compare September 18, 2024 13:09
@dyc3 dyc3 force-pushed the html-feature-flag branch from 00b9fdf to 7e1922d Compare September 18, 2024 13:15
@dyc3 dyc3 mentioned this pull request Sep 18, 2024
Closed
1 task
@dyc3 dyc3 requested review from a team and ematipico September 18, 2024 15:41
This was referenced Sep 18, 2024
Closed
Closed
Merged
@ematipico ematipico merged commit 02f6595 into main Sep 19, 2024
13 checks passed
@ematipico ematipico deleted the html-feature-flag branch September 19, 2024 07:47
@dyc3 dyc3 mentioned this pull request Sep 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ematipico ematipico ematipico approved these changes

Assignees

No one assigned

Labels

A-CLI Area: CLI A-Project Area: project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dyc3 @ematipico
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载