+
Skip to content

Conversation

Jayllyz
Copy link
Contributor

@Jayllyz Jayllyz commented Sep 15, 2024

Summary

Installing the toolchain can take a long time in macOS because of this issue : moonrepo/setup-rust#22

ex workflows where this happens:
https://github.com/biomejs/biome/actions/runs/10872714495/job/30168050791

Test Plan

Should work.

Copy link
Member

@nhedger nhedger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea. Can you add the env only to the relevant steps? Adding it at the workflow level makes the secret available to all steps, even those that don't need it.

@Jayllyz Jayllyz requested a review from nhedger September 15, 2024 17:52
Copy link
Member

@nhedger nhedger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nhedger nhedger merged commit 63bec3e into biomejs:main Sep 15, 2024
2 checks passed
@Jayllyz Jayllyz deleted the chore/setup-rust-403 branch September 15, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载