+
Skip to content

Conversation

mrazauskas
Copy link
Contributor

Summary

This PR adds noConsole options documentation. (The allow option was added in #3786.)

Test Plan

N/A

@github-actions github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Sep 14, 2024
Copy link

codspeed-hq bot commented Sep 14, 2024

CodSpeed Performance Report

Merging #3888 will degrade performances by 10.12%

Comparing mrazauskas:noConsole-options (20d74fc) with main (ce7d090)

Summary

❌ 1 regressions
✅ 106 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main mrazauskas:noConsole-options Change
db_17847247775464589309.json[cached] 12.9 ms 14.3 ms -10.12%

Copy link
Member

@Conaclos Conaclos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I completely forget to document the options.

@Conaclos Conaclos merged commit 713a76e into biomejs:main Sep 14, 2024
11 of 12 checks passed
@mrazauskas mrazauskas deleted the noConsole-options branch September 14, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Linter Area: linter L-JavaScript Language: JavaScript and super languages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载