fix: let aria-label be valid for useHeadingContent.
#3767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonyshew
commented
Sep 3, 2024
There was a problem hiding this comment.
Just taking the opportunity to remove whitespaces I left in my other fix lines. 😄
anthonyshew
commented
Sep 3, 2024
CodSpeed Performance ReportMerging #3767 will not alter performanceComparing Summary
|
useHeadingContent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
An
aria-labelcan be used to set what a screen reader uses for a heading element, even when the heading element doesn't have content available in its "a11y tree" (e.g. children nodes of the element). There is one exception where a heading tag can have botharia-labelandaria-hidden, which also removes it from the "a11y tree".The logic introduced in this PR reflects the above.
Test Plan
I've updated the snapshots to reflect what should be a valid and invaild use of
aria-label.