fix: edge case in noInteractiveToNonInteractiveRole for <canvas>.
#3728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noInteractiveToNonInteractiveRole for <canvas>.
noInteractiveToNonInteractiveRole for <canvas>.noInteractiveToNonInteractiveRole for <canvas>.
noInteractiveToNonInteractiveRole for <canvas>.noInteractiveToNonInteractiveRole for <canvas>.
anthonyshew
commented
Aug 28, 2024
crates/biome_js_analyze/src/lint/a11y/no_interactive_element_to_noninteractive_role.rs
Outdated
Show resolved
Hide resolved
…o_noninteractive_role.rs
CodSpeed Performance ReportMerging #3728 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
<canvas>element can be givenrole="img"to indicate that the canvas is not meant to be interactive. This can be seen in this PR to the corresponding ESLint plugin rule. I noticed this difference between the ESLint plugin rule and Biome while migrating in our codebase.Additional context on
<canvas>accessibility can be found here: https://pauljadam.com/demos/canvas.htmlTest Plan
I've updated the
valid.jsxfor this rule to reflect the intended change.