fix: noAriaHiddenonFocusable when using a JSX expression
#3708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noAriaHiddenonFocusable when using a JSX expression.
anthonyshew
commented
Aug 23, 2024
crates/biome_js_analyze/src/lint/a11y/no_aria_hidden_on_focusable.rs
Outdated
Show resolved
Hide resolved
dyc3
previously requested changes
Aug 23, 2024
CodSpeed Performance ReportMerging #3708 will not alter performanceComparing Summary
|
noAriaHiddenonFocusable when using a JSX expression.noAriaHiddenonFocusable when using a JSX expression.
noAriaHiddenonFocusable when using a JSX expression.noAriaHiddenonFocusable when using a JSX expression
noAriaHiddenonFocusable when using a JSX expressionnoAriaHiddenonFocusable when using a JSX expression
ematipico
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Thank you very much for the bug fix. Everything looks good. I would complete the PR with:
- making the code shared, now that there's a use case
- add a changelog line to
CHANGELOG.md
crates/biome_js_analyze/src/lint/a11y/no_aria_hidden_on_focusable.rs
Outdated
Show resolved
Hide resolved
e6013fc to
4a42a59
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I ran into a bug with JSX expressions for this rule, as seen in #3689. In this PR, we're handling the various ways you can define this attribute with slightly more robustness.
Test Plan
I've added to the
valid.jsxfile for this rule to recreate the bug I ran into. It passes now!