feat(css_semantic): build semantic model for css #3546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #3546 will not alter performanceComparing Summary
|
f21a2fe to
96c9fc3
Compare
ematipico
approved these changes
Aug 5, 2024
| } | ||
|
|
||
| #[derive(Debug, Clone, PartialEq, Eq, PartialOrd, Ord, Default)] | ||
| pub struct Specificity(pub u32, pub u32, pub u32); |
There was a problem hiding this comment.
We should document what are these tree numbers and how they affect the specificity
Comment on lines
33
to
86
| pub(crate) struct SemanticModelData { | ||
| pub(crate) root: CssRoot, | ||
| // Map to each by its range | ||
| pub(crate) node_by_range: FxHashMap<TextRange, CssSyntaxNode>, | ||
| pub(crate) rules: Vec<Rule>, | ||
| } | ||
|
|
||
| #[derive(Debug)] | ||
| pub struct Rule { | ||
| pub selectors: Vec<Selector>, | ||
| pub declarations: Vec<Declaration>, | ||
| pub children: Vec<Rule>, | ||
| pub range: TextRange, | ||
| } | ||
|
|
||
| #[derive(Debug, Clone)] | ||
| pub struct Declaration { | ||
| pub property: String, | ||
| pub value: String, | ||
| pub property_range: TextRange, | ||
| pub value_range: TextRange, | ||
| } | ||
|
|
||
| #[derive(Debug, Clone)] | ||
| pub struct Selector { | ||
| pub name: String, | ||
| pub range: TextRange, | ||
| pub specificity: Specificity, | ||
| } |
There was a problem hiding this comment.
We should document all these types
Comment on lines
51
to
53
| if let Some(property) = node.first_child() { | ||
| if let Some(property_name) = property.first_child() { | ||
| if let Some(value) = property_name.next_sibling() { |
There was a problem hiding this comment.
We can reduce these three Some into one:
if let Some(value) = node.first_child()
.and_then(|p| p.first_child())
.and_then(|p| p.next_sibling()) {
}
crates/biome_css_semantic/Cargo.toml
Outdated
| [package] | ||
| authors.workspace = true | ||
| categories.workspace = true | ||
| description = "<DESCRIPTION>" |
1161edb to
40425e8
Compare
f67de29 to
a3c2f86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces the semantic model for css. The first usecase might be these linter rules.
stylelint/declaration-block-no-duplicate-properties#2784I'll try to supprt more cases and integrate the analyzer in another PR later.
Example
Playground
Test Plan
CI should pass