feat(biome_css_analyzer): implement function-linear-gradient-no-nonstandard-direction #2911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #2911 will not alter performanceComparing Summary
|
ematipico
reviewed
May 18, 2024
crates/biome_css_analyze/src/lint/nursery/no_invalid_direction_in_linear_gradient.rs
Outdated
Show resolved
Hide resolved
crates/biome_css_analyze/src/lint/nursery/no_invalid_direction_in_linear_gradient.rs
Outdated
Show resolved
Hide resolved
crates/biome_css_analyze/src/lint/nursery/no_invalid_direction_in_linear_gradient.rs
Outdated
Show resolved
Hide resolved
crates/biome_css_analyze/src/lint/nursery/no_invalid_direction_in_linear_gradient.rs
Show resolved
Hide resolved
crates/biome_css_analyze/src/lint/nursery/no_invalid_direction_in_linear_gradient.rs
Outdated
Show resolved
Hide resolved
crates/biome_css_analyze/src/lint/nursery/no_invalid_direction_in_linear_gradient.rs
Show resolved
Hide resolved
crates/biome_css_analyze/src/lint/nursery/no_invalid_direction_in_linear_gradient.rs
Show resolved
Hide resolved
crates/biome_css_analyze/src/lint/nursery/no_invalid_direction_in_linear_gradient.rs
Outdated
Show resolved
Hide resolved
…tion-in-linear-gradient
ematipico
reviewed
May 30, 2024
crates/biome_css_analyze/src/lint/nursery/no_invalid_direction_in_linear_gradient.rs
Show resolved
Hide resolved
crates/biome_css_analyze/src/lint/nursery/no_invalid_direction_in_linear_gradient.rs
Outdated
Show resolved
Hide resolved
…tion-in-linear-gradient
mdm317
commented
Jun 14, 2024
There was a problem hiding this comment.
@ematipico
I removed the existing regular expressions that were used for case-insensitive matching.
I left the remaining regular expressions because I think implementing them without regex would be challenging and complex.
Should I also remove these remaining regular expressions?
Could you provide some advice on this?
crates/biome_css_analyze/src/lint/nursery/no_invalid_direction_in_linear_gradient.rs
Show resolved
Hide resolved
crates/biome_css_analyze/src/lint/nursery/no_invalid_direction_in_linear_gradient.rs
Show resolved
Hide resolved
crates/biome_css_analyze/src/lint/nursery/no_invalid_direction_in_linear_gradient.rs
Show resolved
Hide resolved
ematipico
approved these changes
Jun 17, 2024
This was referenced Aug 28, 2024
This was referenced Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2808
Summary
implements function-linear-gradient-no-nonstandard-direction
Test Plan
Add test cases