+
Skip to content

chore: upgrade to rust 1.78 #2691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2024
Merged

chore: upgrade to rust 1.78 #2691

merged 1 commit into from
May 3, 2024

Conversation

ematipico
Copy link
Member

Summary

The compiler and clippy got better and I had to remove a bunch of unused code. However, there are some false positives (the empty_docs in biome_wasm) and things to review around the FormatInto inside the JSON formatter: weirdly, the trait isn't flagged inside other crates.

Test Plan

CI should pass

@github-actions github-actions bot added A-CLI Area: CLI A-Core Area: core A-Project Area: project A-Linter Area: linter A-Parser Area: parser A-Formatter Area: formatter L-JavaScript Language: JavaScript and super languages L-CSS Language: CSS L-JSON Language: JSON and super languages labels May 3, 2024
@ematipico ematipico requested review from a team May 3, 2024 08:25
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 3, 2024

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 49701 49701 0
Passed 48721 48721 0
Failed 980 980 0
Panics 0 0 0
Coverage 98.03% 98.03% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6322 6322 0
Passed 2036 2036 0
Failed 4286 4286 0
Panics 0 0 0
Coverage 32.20% 32.20% 0.00%

ts/babel

Test result main count This PR count Difference
Total 662 662 0
Passed 593 593 0
Failed 69 69 0
Panics 0 0 0
Coverage 89.58% 89.58% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17646 17646 0
Passed 13439 13439 0
Failed 4205 4205 0
Panics 2 2 0
Coverage 76.16% 76.16% 0.00%

arendjr
arendjr approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@arendjr arendjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented May 3, 2024

CodSpeed Performance Report

Merging #2691 will improve performances by 8.05%

Comparing chore/bump-rust (e2a0562) with main (1f891f5)

Summary

⚡ 2 improvements
✅ 86 untouched benchmarks

Benchmarks breakdown

Benchmark main chore/bump-rust Change
⚡ dojo.js[cached] 45.7 ms 42.6 ms +7.31%
⚡ db.json[uncached] 87 ms 80.5 ms +8.05%

@ematipico ematipico merged commit 7656d1b into main May 3, 2024
@ematipico ematipico deleted the chore/bump-rust branch May 3, 2024 08:59
@DeltaV93 DeltaV93 mentioned this pull request Jun 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arendjr arendjr arendjr approved these changes

Assignees

No one assigned

Labels

A-CLI Area: CLI A-Core Area: core A-Formatter Area: formatter A-Linter Area: linter A-Parser Area: parser A-Project Area: project L-CSS Language: CSS L-JavaScript Language: JavaScript and super languages L-JSON Language: JSON and super languages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ematipico @arendjr
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载