refactor(deserialize): don't handle Option specifically #2630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A few days ago, while working on #1859, I found some possible simplification.
Because, I am no longer sure that #1859 is a good idea, I decided to extract the main simplifications in this PR.
The idea is to implement
DeserializableforOption.This allows to remove specific handling of
Optionin theDeserializablederive macro.I also simplified the
Mergederive macro, which was more complex than it needed to be.I also removed the implementations that allow an instance to be converted to a partial instance.
It is never used and has a conceptual flaw: it assumes that a field is unset with its default value.
Test Plan
CI should pass.