+
Skip to content

Conversation

l0ngvh
Copy link
Contributor

@l0ngvh l0ngvh commented Apr 18, 2024

Summary

Parse GraphQL fragment definition. This is a small case so I parse both the happy path and error path in this PR

Test Plan

All test should pass

@l0ngvh l0ngvh marked this pull request as ready for review April 18, 2024 09:06
@l0ngvh l0ngvh force-pushed the feat-graphql-parse-fragment-difinition branch from 7762c3b to e29aba3 Compare April 18, 2024 09:06
Copy link

codspeed-hq bot commented Apr 18, 2024

CodSpeed Performance Report

Merging #2506 will improve performances by 9.95%

Comparing vohoanglong0107:feat-graphql-parse-fragment-difinition (0f8b5df) with main (f3afb52)

Summary

⚡ 1 improvements
✅ 92 untouched benchmarks

Benchmarks breakdown

Benchmark main vohoanglong0107:feat-graphql-parse-fragment-difinition Change
router.ts[cached] 11.6 ms 10.6 ms +9.95%

@l0ngvh l0ngvh changed the title feat: parse fragment definition for Graphql feat(biome_graphql_parser): parse fragment definition Apr 22, 2024
@l0ngvh l0ngvh force-pushed the feat-graphql-parse-fragment-difinition branch from e29aba3 to 0f8b5df Compare April 22, 2024 09:03
@ematipico ematipico merged commit a094dac into biomejs:main Apr 22, 2024
@l0ngvh l0ngvh deleted the feat-graphql-parse-fragment-difinition branch April 22, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载