+
Skip to content

fix: reverts hashbrown, which causes issues when compiling to WASM #2496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 17, 2024
Merged

fix: reverts hashbrown, which causes issues when compiling to WASM #2496

merged 2 commits into from
Apr 17, 2024

Conversation

ematipico
Copy link
Member

Summary

This PR reverts hashbrown. The latest version is breaking the WASM distribution.

We will look into this later, maybe by using features.

I also added hashbrown and pulldown-cmark to the ignored deps in renovate, because they contain breaking changes.

Test Plan

CI should pass

@github-actions github-actions bot added the A-Core Area: core label Apr 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 49701 49701 0
Passed 48721 48721 0
Failed 980 980 0
Panics 0 0 0
Coverage 98.03% 98.03% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6322 6322 0
Passed 2036 2036 0
Failed 4286 4286 0
Panics 0 0 0
Coverage 32.20% 32.20% 0.00%

ts/babel

Test result main count This PR count Difference
Total 662 662 0
Passed 593 593 0
Failed 69 69 0
Panics 0 0 0
Coverage 89.58% 89.58% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17646 17646 0
Passed 13439 13439 0
Failed 4205 4205 0
Panics 2 2 0
Coverage 76.16% 76.16% 0.00%

@ematipico ematipico merged commit 3b59a05 into main Apr 17, 2024
@ematipico ematipico deleted the fix/revert-hashbrown branch April 17, 2024 15:02
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Apr 17, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #2496 will not alter performance

Comparing fix/revert-hashbrown (630e443) with main (2608c16)

Summary

✅ 93 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-Core Area: core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ematipico
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载