fix(codegen): new lint rule generation #2187
Merged
+13
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for biomejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ematipico
approved these changes
Mar 25, 2024
unvalley
commented
Mar 25, 2024
Comment on lines
+80
to
+81
| let _binding = ctx.query(); | ||
| Some(()) |
There was a problem hiding this comment.
The default template should emit diagnostic.
I think here we don't need to implement the rule because this is a template, so commenting out valid cases. Developers will delete the template before starting the dev.
ematipico
approved these changes
Mar 25, 2024
Comment on lines
65
to
67
| 1. The `Ast` query type allows you to query the AST of a program. | ||
| 1. The `State` type doesn't have to be used, so it can be considered optional. However, it has to be defined as `type State = ()`. | ||
| 1. Implement the `run` function: |
There was a problem hiding this comment.
This was intentional, can you revert it please? If you list all numbers to 1. they will rendered automatically in order. This means you just need to add another 1 in case you're adding a new step in middle.
It's really convenient.
There was a problem hiding this comment.
oh, I didn't know that. I restore the change!
ematipico
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In
generate_new_lintrule.rs, this PR fixesnode.range()becausereferenceisn't definedsrc/lint/nurseryTest Plan
Executed
just new-js-lintrule ruleNamewithout fail