+
Skip to content

CSS parser parses sequence of custom idents for @font-feature-values #1743 #2184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 25, 2024
Merged

CSS parser parses sequence of custom idents for @font-feature-values #1743 #2184

merged 3 commits into from
Mar 25, 2024

Conversation

denbezrukov
Copy link
Contributor

Summary

See #1743

Test Plan

cargo test

@github-actions github-actions bot added A-Parser Area: parser A-Formatter Area: formatter A-Tooling Area: internal tools L-CSS Language: CSS labels Mar 24, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 24, 2024 •
edited
Loading

✅ Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit e7d3675
🔍 Latest deploy log https://app.netlify.com/sites/biomejs/deploys/6601e0d0eb44dc000826383f
😎 Deploy Preview https://deploy-preview-2184--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (🔴 down 3 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link
Contributor

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 49701 49701 0
Passed 48721 48721 0
Failed 980 980 0
Panics 0 0 0
Coverage 98.03% 98.03% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6322 6322 0
Passed 2036 2036 0
Failed 4286 4286 0
Panics 0 0 0
Coverage 32.20% 32.20% 0.00%

ts/babel

Test result main count This PR count Difference
Total 662 662 0
Passed 593 593 0
Failed 69 69 0
Panics 0 0 0
Coverage 89.58% 89.58% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 17646 17646 0
Passed 13439 13439 0
Failed 4205 4205 0
Panics 2 2 0
Coverage 76.16% 76.16% 0.00%

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 24, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #2184 will not alter performance

Comparing feat/font-feature-values (e7d3675) with main (3fdf1ee)

Summary

✅ 93 untouched benchmarks

@denbezrukov denbezrukov force-pushed the feat/font-feature-values branch from fb16151 to 72830fc Compare March 25, 2024 20:24
@denbezrukov denbezrukov merged commit 2084907 into main Mar 25, 2024
@denbezrukov denbezrukov deleted the feat/font-feature-values branch March 25, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-Formatter Area: formatter A-Parser Area: parser A-Tooling Area: internal tools L-CSS Language: CSS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@denbezrukov
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载