chore: add html parser crate #2163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for biomejs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Parser conformance results onjs/262
jsx/babel
symbols/microsoft
ts/babel
ts/microsoft
|
CodSpeed Performance ReportMerging #2163 will improve performances by 6.23%Comparing Summary
Benchmarks breakdown
|
arendjr
approved these changes
Mar 24, 2024
| /// | ||
| /// ## Safety | ||
| /// Must be called at a valid UT8 char boundary | ||
| fn current_char_unchecked(&self) -> char { |
There was a problem hiding this comment.
This function is in the generic lexer now.
| } | ||
|
|
||
| impl<'src> HtmlLexer<'src> { | ||
| /// Make a new lexer from a str, this is safe because strs are valid utf8 |
There was a problem hiding this comment.
The safety comment seems a bit out of place, since there’s nothing unsafe here.
|
|
||
| impl<'src> HtmlLexer<'src> { | ||
| fn consume_token(&mut self, current: u8) -> HtmlSyntaxKind { | ||
| // The speed difference comes from the difference in table size, a 2kb table is easily fit into cpu cache |
There was a problem hiding this comment.
What speed difference? This comment lacks context.
crates/biome_html_parser/src/lib.rs
Outdated
| use biome_parser::diagnostic::ParseDiagnostic; | ||
| use biome_rowan::{AstNode, NodeCache}; | ||
|
|
||
| /// Parses the provided string as CSS program using the provided node cache. |
9674e95 to
6d1566d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR just adds a new
biome_html_parsercrate. The crate doesn't have any logic yet, just some plumbing the start the infrastructure.I took the opportunity to do some further refactor around the lexer.
Test Plan
Currect CI should pass