-
-
Notifications
You must be signed in to change notification settings - Fork 715
feat(biome_js_analyze): added support for React 19.2 #7669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 670a59b The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughAdds React 19.2 support by recognising Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Thank you! Please add a changeset as the bot suggests |
CodSpeed Performance ReportMerging #7669 will not alter performanceComparing Summary
Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please send the PR towards the next
branch, as explained in the contribution guideline
added new hook to `useExhaustiveDependencies` and added new API to API list
My bad, I did see that but clearly forgot again. I have now rebased to |
This comment was marked as spam.
This comment was marked as spam.
@barklund It looks like the CI is still failing. Could you take a look? |
Summary
This PR updates Biome’s React integration to reflect the React 19.2 release:
useEffectEvent
is now treated likeuseRef
in theuseExhaustiveDependencies
rule:<Activity />
anduseEffectEvent
has been added to the list of known React components.Fixes #7631.
Test Plan
useExhaustiveDependencies/valid.js
to confirm thatuseEffectEvent
is not required in dependency arrays.useExhaustiveDependencies/missingDependenciesInvalid.jsx
to ensure addinguseEffectEvent
does not impact existing tests.All tests pass locally.
Docs
No new user-facing rules or options introduced.
No documentation updates required beyond the implicit coverage in the existing rule docs.