+
Skip to content

fix(cli): include plugin rule in summary report #7643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 3, 2025
Merged

fix(cli): include plugin rule in summary report #7643

merged 3 commits into from
Oct 3, 2025

Conversation

daivinhtran
Copy link
Contributor

@daivinhtran daivinhtran commented Oct 2, 2025 •
edited by coderabbitai bot
Loading

Fixes #7580

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 286984d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@biomejs/biome Patch
@biomejs/cli-win32-x64 Patch
@biomejs/cli-win32-arm64 Patch
@biomejs/cli-darwin-x64 Patch
@biomejs/cli-darwin-arm64 Patch
@biomejs/cli-linux-x64 Patch
@biomejs/cli-linux-arm64 Patch
@biomejs/cli-linux-x64-musl Patch
@biomejs/cli-linux-arm64-musl Patch
@biomejs/wasm-web Patch
@biomejs/wasm-bundler Patch
@biomejs/wasm-nodejs Patch
@biomejs/backend-jsonrpc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 2, 2025 •
edited
Loading

Walkthrough

The summary reporter now treats diagnostics whose category name starts with "plugin" as rule diagnostics to be collected alongside existing categories like "lint/", "suppressions/" and "assist/". Tests were updated to add a PLUGIN fixture, write a plugin.grit and a biome.json in the lint-summary test setup so plugin-generated diagnostics are exercised. A changeset was added recording a patch for @biomejs/biome referencing the fix.

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Title Check ✅ Passed The title precisely states the main change by indicating the CLI summary reporter will now include plugin rules, matching the modifications in the changeset. It is concise, clear, and directly reflects the core update introduced by this pull request.
Linked Issues Check ✅ Passed The implementation extends the summary reporter to include plugin categories, adds tests to verify plugin output, and updates the changeset version, fully satisfying the coding requirements of issue #7580.
Out of Scope Changes Check ✅ Passed All modifications, including changes to diagnostic categorization, test setup, and the changeset file, are directly focused on including plugin output in the summary reporter with no unrelated code present.
Description Check ✅ Passed The description references the linked issue #7580 and clearly indicates that this pull request fixes that specific problem, making it directly related to the changeset.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d873faf and 286984d.

📒 Files selected for processing (1)
  • .changeset/warm-shrimps-wait.md (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .changeset/warm-shrimps-wait.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: Documentation
  • GitHub Check: Lint project (depot-ubuntu-24.04-arm-16)
  • GitHub Check: Lint project (depot-windows-2022)
  • GitHub Check: Check Dependencies
  • GitHub Check: Test (depot-windows-2022-16)
  • GitHub Check: Test (depot-ubuntu-24.04-arm-16)
  • GitHub Check: autofix
  • GitHub Check: Test Node.js API

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the A-CLI Area: CLI label Oct 2, 2025
@daivinhtran daivinhtran marked this pull request as draft October 2, 2025 16:37
@daivinhtran daivinhtran force-pushed the fix-reporter-summary-for-plugin branch 4 times, most recently from 9b10d31 to 9855d0d Compare October 2, 2025 17:15
@daivinhtran daivinhtran force-pushed the fix-reporter-summary-for-plugin branch from 9855d0d to 6a0b9c0 Compare October 2, 2025 17:26
@daivinhtran daivinhtran changed the title fix(cli): include plugin category output of --reporter=summary fix(cli): include plugin rule in summary report Oct 2, 2025
@daivinhtran daivinhtran marked this pull request as ready for review October 2, 2025 17:30
ematipico
ematipico reviewed Oct 3, 2025
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot the changeset

@daivinhtran
Copy link
Contributor Author

You forgot the changeset

@ematipico thanks! I just added it.

I forget the changeset every single time. Since CodeRabbit has enough context about my changes, we might be able to enforce this automatically via CodeRabbit.

@daivinhtran daivinhtran mentioned this pull request Oct 3, 2025
Closed
@daivinhtran daivinhtran force-pushed the fix-reporter-summary-for-plugin branch from d873faf to 286984d Compare October 3, 2025 09:40
@daivinhtran
Copy link
Contributor Author

I forget the changeset every single time. Since CodeRabbit has enough context about my changes, we might be able to enforce this automatically via CodeRabbit.

My bad. I saw the changeset-bot now.

@ematipico ematipico merged commit 459a6ac into biomejs:main Oct 3, 2025
13 checks passed
@github-actions github-actions bot mentioned this pull request Oct 3, 2025
Merged
ematipico pushed a commit that referenced this pull request Oct 3, 2025
@daivinhtran @autofix-ci @ematipico
fix(cli): include plugin rule in summary report (#7643)
a509b4d 
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ematipico ematipico ematipico approved these changes

Assignees

No one assigned

Labels

A-CLI Area: CLI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

💅 Plugin output not being reported with summary reporter

2 participants

@daivinhtran @ematipico
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载