+
Skip to content

chore: upgrade to rust 1.90.0 #7642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 2, 2025
Merged

chore: upgrade to rust 1.90.0 #7642

merged 2 commits into from
Oct 2, 2025

Conversation

ematipico
Copy link
Member

@ematipico ematipico commented Oct 2, 2025 •
edited
Loading

Summary

Upgrade to the latest version of Rust, and apply new clippies.

Test Plan

CI should pass

Docs

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: c902171

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added A-Parser Area: parser A-Formatter Area: formatter L-CSS Language: CSS L-JSON Language: JSON and super languages labels Oct 2, 2025
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 2, 2025

Walkthrough

This change removes KeyframesItemBlockParseRecovery from the CSS keyframes parser, consolidating recovery on KeyframesItemListParseRecovery (recovered kind: CSS_BOGUS_KEYFRAMES_ITEM). The previous recovered kind CSS_BOGUS_BLOCK and its associated logic are dropped. In the JSON formatter tests, the TestOptions helper struct (with derives and cases field) is removed; the From for JsonFormatOptions implementation remains. The Rust toolchain is bumped from 1.89.0 to 1.90.0 in rust-toolchain.toml.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly and concisely identifies the main change as upgrading the Rust toolchain to version 1.90.0, matching the changes in the toolchain file. It uses a standard “chore:” prefix and avoids extraneous details, making the purpose immediately obvious to reviewers.
Description Check ✅ Passed The description summarises the intent to upgrade to the latest Rust version and mentions the application of new Clippy lints, which aligns with the toolchain bump in the changeset and the code adjustments. It also provides a basic test plan, confirming that CI should pass after the upgrade.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/rust-1.90.0
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d025e53 and c5861b4.

📒 Files selected for processing (3)
  • crates/biome_css_parser/src/syntax/at_rule/keyframes.rs (0 hunks)
  • crates/biome_json_formatter/tests/language.rs (0 hunks)
  • rust-toolchain.toml (1 hunks)
💤 Files with no reviewable changes (2)
  • crates/biome_json_formatter/tests/language.rs
  • crates/biome_css_parser/src/syntax/at_rule/keyframes.rs
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{rs,toml}

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Before committing, format Rust and TOML files (e.g., via just f/just format)

Files:

  • rust-toolchain.toml
**/*.toml

📄 CodeRabbit inference engine (CONTRIBUTING.md)

Format TOML files with taplo (taplo-cli)

Files:

  • rust-toolchain.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (24)
  • GitHub Check: Documentation
  • GitHub Check: Test (depot-ubuntu-24.04-arm-16)
  • GitHub Check: Test (depot-windows-2022-16)
  • GitHub Check: Lint project (depot-ubuntu-24.04-arm-16)
  • GitHub Check: Lint project (depot-windows-2022)
  • GitHub Check: Check Dependencies
  • GitHub Check: Test Node.js API
  • GitHub Check: Bench (biome_package)
  • GitHub Check: Bench (biome_html_formatter)
  • GitHub Check: Bench (biome_module_graph)
  • GitHub Check: Bench (biome_configuration)
  • GitHub Check: Bench (biome_json_parser)
  • GitHub Check: autofix
  • GitHub Check: Bench (biome_css_parser)
  • GitHub Check: Bench (biome_json_analyze)
  • GitHub Check: Bench (biome_html_parser)
  • GitHub Check: Bench (biome_css_analyze)
  • GitHub Check: Bench (biome_graphql_parser)
  • GitHub Check: Bench (biome_js_formatter)
  • GitHub Check: Bench (biome_js_analyze)
  • GitHub Check: Bench (biome_graphql_formatter)
  • GitHub Check: Bench (biome_css_formatter)
  • GitHub Check: Bench (biome_json_formatter)
  • GitHub Check: Bench (biome_js_parser)
🔇 Additional comments (1)
rust-toolchain.toml (1)

5-5: Rust 1.90.0 bump looks spot on

Channel switch is tidy; no further tweaks needed.

Comment @coderabbitai help to get the list of available commands and usage tips.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 2, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #7642 will not alter performance

Comparing chore/rust-1.90.0 (c902171) with main (41df59b)1

Summary

✅ 29 untouched
⏩ 111 skipped2

Footnotes

  1. No successful run was found on main (acbd9cc) during the generation of this report, so 41df59b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 111 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@ematipico ematipico merged commit 8cefae2 into main Oct 2, 2025
19 checks passed
@ematipico ematipico deleted the chore/rust-1.90.0 branch October 2, 2025 15:29
ematipico added a commit that referenced this pull request Oct 3, 2025
@ematipico
chore: upgrade to rust 1.90.0 (#7642)
a4e9064
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@siketyan siketyan siketyan approved these changes

Assignees

No one assigned

Labels

A-Formatter Area: formatter A-Parser Area: parser L-CSS Language: CSS L-JSON Language: JSON and super languages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ematipico @siketyan
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载