+
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
19ee305
feat(biome_js_analyze): align no_unused_private_class_members_with_se…
vladimir-ivanov Sep 28, 2025
0b4b6be
feat(biome_js_analyze): align no_unused_private_class_members_with_se…
vladimir-ivanov Sep 29, 2025
0b50aad
Merge branch 'main' into feat/no_unused_private_class_members_semanti…
vladimir-ivanov Sep 29, 2025
a66a6c9
Update .changeset/no_unused_private_class_members_amended.md
vladimir-ivanov Sep 29, 2025
7d7ff8f
Update crates/biome_js_analyze/tests/specs/correctness/noUnusedPrivat…
vladimir-ivanov Sep 29, 2025
01e7abb
Update crates/biome_js_analyze/src/lint/correctness/no_unused_private…
vladimir-ivanov Sep 29, 2025
b937419
feat(biome_js_analyze): align no_unused_private_class_members_with_se…
vladimir-ivanov Sep 29, 2025
adfd844
feat(biome_js_analyze): align no_unused_private_class_members_with_se…
vladimir-ivanov Sep 29, 2025
0c5c7ae
feat(biome_js_analyze): align no_unused_private_class_members_with_se…
vladimir-ivanov Sep 30, 2025
84c91b3
feat(biome_js_analyze): align no_unused_private_class_members_with_se…
vladimir-ivanov Oct 3, 2025
dcdad70
feat(biome_js_analyze): align no_unused_private_class_members_with_se…
vladimir-ivanov Oct 3, 2025
6e444ec
Merge branch 'main' into feat/no_unused_private_class_members_semanti…
vladimir-ivanov Oct 4, 2025
34e433f
feat(biome_js_analyze): align no_unused_private_class_members_with_se…
vladimir-ivanov Oct 4, 2025
38035b9
feat(biome_js_analyze): align no_unused_private_class_members_with_se…
vladimir-ivanov Oct 5, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions .changeset/no_unused_private_class_members_amended.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
---
"@biomejs/biome": patch
---

Changed [`noUnusedPrivateClassMembers`](https://biomejs.dev/linter/rules/no-unused-private-class-members/) to align more fully with meaningful reads.

This rule now distinguishes more carefully between writes and reads of private class members.

- A *meaningful read* is any access that affects program behavior.
- For example, `this.#x += 1` both reads and writes `#x`, so it counts as usage.
- Pure writes without a read (e.g. `this.#x = 1` with no getter) are no longer treated as usage.

This change ensures that private members are only considered “used” when they are actually read in a way that influences execution.

***Invalid examples (previously valid)***

```ts
class UsedMember {
set #x(value) {
doSomething(value);
}

foo() {
// This assignment does not actually read #x, because there is no getter.
// Previously, this was considered a usage, but now it’s correctly flagged.
this.#x = 1;
}
}
```

***Valid example (Previously invalid)***

```js
class Foo {
#usedOnlyInWriteStatement = 5;

method() {
// This counts as a meaningful read because we both read and write the value.
this.#usedOnlyInWriteStatement += 42;
}
}
```

***Summary***
• Only accesses that read a value are considered meaningful for the purpose of this rule.
• Simple assignments to a setter without a corresponding getter no longer count as usage.
• Operations like +=, method calls returning a value, or reading the property for computation are considered meaningful reads.
Loading
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载