-
-
Notifications
You must be signed in to change notification settings - Fork 718
feat(biome_js_analyze): align no_unused_private_class_members_with_semantic_class #7610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
vladimir-ivanov
wants to merge
14
commits into
biomejs:main
from
vladimir-ivanov:feat/no_unused_private_class_members_semantic_class
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
19ee305
feat(biome_js_analyze): align no_unused_private_class_members_with_se…
vladimir-ivanov 0b4b6be
feat(biome_js_analyze): align no_unused_private_class_members_with_se…
vladimir-ivanov 0b50aad
Merge branch 'main' into feat/no_unused_private_class_members_semanti…
vladimir-ivanov a66a6c9
Update .changeset/no_unused_private_class_members_amended.md
vladimir-ivanov 7d7ff8f
Update crates/biome_js_analyze/tests/specs/correctness/noUnusedPrivat…
vladimir-ivanov 01e7abb
Update crates/biome_js_analyze/src/lint/correctness/no_unused_private…
vladimir-ivanov b937419
feat(biome_js_analyze): align no_unused_private_class_members_with_se…
vladimir-ivanov adfd844
feat(biome_js_analyze): align no_unused_private_class_members_with_se…
vladimir-ivanov 0c5c7ae
feat(biome_js_analyze): align no_unused_private_class_members_with_se…
vladimir-ivanov 84c91b3
feat(biome_js_analyze): align no_unused_private_class_members_with_se…
vladimir-ivanov dcdad70
feat(biome_js_analyze): align no_unused_private_class_members_with_se…
vladimir-ivanov 6e444ec
Merge branch 'main' into feat/no_unused_private_class_members_semanti…
vladimir-ivanov 34e433f
feat(biome_js_analyze): align no_unused_private_class_members_with_se…
vladimir-ivanov 38035b9
feat(biome_js_analyze): align no_unused_private_class_members_with_se…
vladimir-ivanov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
--- | ||
"@biomejs/biome": patch | ||
--- | ||
|
||
Changed [`noUnusedPrivateClassMembers`](https://biomejs.dev/linter/rules/no-unused-private-class-members/) to align more fully with meaningful reads. | ||
|
||
This rule now distinguishes more carefully between writes and reads of private class members. | ||
|
||
- A *meaningful read* is any access that affects program behavior. | ||
- For example, `this.#x += 1` both reads and writes `#x`, so it counts as usage. | ||
- Pure writes without a read (e.g. `this.#x = 1` with no getter) are no longer treated as usage. | ||
|
||
This change ensures that private members are only considered “used” when they are actually read in a way that influences execution. | ||
|
||
***Invalid examples (previously valid)*** | ||
|
||
```ts | ||
class UsedMember { | ||
set #x(value) { | ||
doSomething(value); | ||
} | ||
|
||
foo() { | ||
// This assignment does not actually read #x, because there is no getter. | ||
// Previously, this was considered a usage, but now it’s correctly flagged. | ||
this.#x = 1; | ||
} | ||
} | ||
``` | ||
|
||
***Valid example (Previously invalid)*** | ||
|
||
```js | ||
class Foo { | ||
#usedOnlyInWriteStatement = 5; | ||
|
||
method() { | ||
// This counts as a meaningful read because we both read and write the value. | ||
this.#usedOnlyInWriteStatement += 42; | ||
} | ||
} | ||
``` | ||
|
||
***Summary*** | ||
• Only accesses that read a value are considered meaningful for the purpose of this rule. | ||
• Simple assignments to a setter without a corresponding getter no longer count as usage. | ||
• Operations like +=, method calls returning a value, or reading the property for computation are considered meaningful reads. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.