crates/biome_html_syntax/src/script_type.rs (1)

30-45: Normalise MIME values; treat +json as JSON and ignore parameters

Real‑world type values often include parameters (e.g. application/json; charset=utf-8) or JSON subtypes (e.g. application/ld+json). Trim, strip params, and recognise +json subtypes. Also consider text/ecmascript as classic JS.

Apply this diff:

 pub fn from_type_value(type_value: &str) -> Self {
-        if type_value.eq_ignore_ascii_case("module") {
+        // Normalise: trim and drop parameters after ';'
+        let mime = type_value.split(';').next().unwrap_or(type_value).trim();
+
+        if mime.eq_ignore_ascii_case("module") {
             Self::Module
-        } else if type_value.eq_ignore_ascii_case("text/javascript")
-            || type_value.eq_ignore_ascii_case("application/javascript")
-            || type_value.eq_ignore_ascii_case("application/ecmascript")
+        } else if mime.eq_ignore_ascii_case("text/javascript")
+            || mime.eq_ignore_ascii_case("application/javascript")
+            || mime.eq_ignore_ascii_case("application/ecmascript")
+            || mime.eq_ignore_ascii_case("text/ecmascript")
         {
             Self::Classic
-        } else if type_value.eq_ignore_ascii_case("importmap") {
+        } else if mime.eq_ignore_ascii_case("importmap") {
             Self::ImportMap
-        } else if type_value.eq_ignore_ascii_case("application/json") {
+        } else if mime.eq_ignore_ascii_case("application/json") || mime.to_ascii_lowercase().ends_with("+json") {
             Self::JSON
         } else {
             Self::Unsupported
         }
     }

crates/biome_html_syntax/src/element_ext.rs (1)

132-154: Tiny DRY: factor tag-name check helper

is_style_tag and is_script_tag duplicate the same token extraction. Consider a small helper like fn has_tag_name(&self, name: &str) -> bool and reuse it.

crates/biome_service/src/file_handlers/html.rs (1)

300-343: Nit: function name reads redundantly

parse_embedded_js_script is a bit tautological. parse_embedded_js would do.

crates/biome_service/src/workspace/document.rs (1)

99-124: Docs reference JavaScript in a generic type

EmbeddedContent<L> comments still talk about JavaScript. Reword to be language‑agnostic to avoid confusion.

Apply this diff to the doc comments:

-/// Represents embedded content extracted from HTML documents.
-///
-/// This struct stores parsing metadata and provides access to the parsed
-/// content with offset-aware positioning to maintain correct source locations.
+/// Represents embedded content extracted from HTML documents.
+///
+/// Stores parsing metadata and provides access to the parsed content
+/// with offset-aware positioning to maintain correct source locations.
@@
-    /// The JavaScript source code extracted from the script element.
+    /// The embedded source code extracted from the element.
@@
-    /// The range of the entire script element in the HTML document,
-    /// including the opening and closing tags.
+    /// The range of the entire element in the HTML document,
+    /// including opening/closing tags.
@@
-    /// The range of just the JavaScript content within the script element,
-    /// excluding the script tags themselves.
+    /// The range of just the embedded content within the element,
+    /// excluding the tags themselves.
@@
-    /// The offset where the JavaScript content starts in the parent document.
-    /// This is used for offset-aware parsing.
+    /// The offset where the embedded content starts in the parent document
+    /// (used for offset-aware parsing).

crates/biome_service/src/workspace/server.rs (1)

526-526: Prefer explicit imports over wildcard inside function.

Importing parse_embedded_js_script/parse_embedded_json/parse_embedded_style explicitly (at module scope) avoids pulling in unrelated items and improves grep-ability.

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_js_type_info/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:50:12.090Z
Learning: Applies to crates/biome_js_type_info/src/**/*.rs : Represent links between types using TypeReference (not Arc) to avoid cross-module retention and recursive structures; store type data in linear vectors

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:48:27.774Z
Learning: Applies to crates/biome_formatter/biome_html_formatter/src/cst.rs : Define FormatHtmlSyntaxNode in cst.rs and implement FormatRule<HtmlSyntaxNode>, plus AsFormat and IntoFormat for HtmlSyntaxNode using the provided mapping code

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:48:27.774Z
Learning: Applies to crates/biome_formatter/biome_html_formatter/tests/spec_test.rs : Create tests/spec_test.rs implementing the run(spec_input_file, _expected_file, test_directory, _file_type) function as shown and include!("language.rs")

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:48:27.774Z
Learning: Applies to crates/biome_formatter/biome_html_formatter/tests/spec_tests.rs : Create tests/spec_tests.rs in the biome_html_formatter crate that generates tests via tests_macros::gen_tests! for all HTML files at tests/specs/html/**/*.html

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:48:27.774Z
Learning: Applies to crates/biome_formatter/biome_html_formatter/tests/language.rs : Create tests/language.rs defining HtmlTestFormatLanguage and implement TestFormatLanguage for it

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_js_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:48:52.001Z
Learning: Applies to crates/biome_js_formatter/**/*.rs : Import the FormatNode trait and implement it for your Node

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_js_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:48:52.001Z
Learning: Applies to crates/biome_js_formatter/**/*.rs : Use the generic Format trait and FormatNode for AST nodes when implementing the formatter

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:48:27.774Z
Learning: Applies to crates/biome_formatter/biome_html_formatter/src/lib.rs : Expose a documented public function format_node(options: HtmlFormatOptions, root: &HtmlSyntaxNode) -> FormatResult<Formatted<HtmlFormatContext>> delegating to biome_formatter::format_node

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_js_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:48:52.001Z
Learning: Applies to crates/biome_js_formatter/**/Cargo.toml : Add biome_js_formatter as a path dependency in Cargo.toml: biome_js_formatter = { version = "0.0.1", path = "../biome_js_formatter" }

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_js_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:48:52.001Z
Learning: Applies to crates/biome_js_formatter/**/*.rs : Build an intermediate IR via the provided helper APIs when formatting

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:48:27.774Z
Learning: Applies to crates/biome_formatter/biome_html_formatter/src/lib.rs : Place the plumbing traits and impls (AsFormat, IntoFormat, FormattedIterExt, and their Iterator adapters) in the biome_html_formatter crate’s lib.rs

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:48:27.774Z
Learning: Applies to crates/biome_formatter/biome_html_formatter/src/cst.rs : Provide the FormatNodeRule trait wiring (fmt, fmt_fields, is_suppressed, fmt_leading_comments, fmt_dangling_comments, fmt_trailing_comments) used to start node formatting

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_js_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:48:52.001Z
Learning: Applies to crates/biome_js_formatter/**/*.rs : When a token is mandatory and present in the AST, use the AST-provided token (e.g., node.l_paren_token().format()) instead of hardcoded tokens

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:48:27.774Z
Learning: Applies to crates/biome_formatter/biome_html_formatter/src/context.rs : Define HtmlFormatContext in context.rs with fields comments: Rc<HtmlComments> and source_map: Option<TransformSourceMap>, and implement FormatContext and CstFormatContext

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_js_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:48:52.001Z
Learning: Applies to crates/biome_js_formatter/**/*.rs : Do not attempt to fix code: if a mandatory token/node is missing, return None instead

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:48:27.774Z
Learning: After scaffolding, replace uses of format_verbatim_node with proper biome_formatter IR to implement real formatting

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_service/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:53:15.299Z
Learning: Applies to crates/biome_service/src/workspace.rs : Implement the Workspace trait in src/workspace.rs

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_service/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:53:15.299Z
Learning: Applies to crates/biome_service/src/workspace/watcher.tests.rs : Place watcher tests for workspace methods in src/workspace/watcher.tests.rs

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:48:27.774Z
Learning: Applies to crates/biome_formatter/biome_html_formatter/src/comments.rs : Define HtmlComments alias and HtmlCommentStyle in comments.rs, and implement CommentStyle for the language

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_parser/CONTRIBUTING.md:0-0
Timestamp: 2025-08-17T08:57:34.751Z
Learning: Applies to crates/biome_parser/xtask/codegen/*.ungram : Union node names must start with Any* (e.g., AnyHtmlAttribute)

Learnt from: CR
PR: biomejs/biome#0
File: CLAUDE.md:0-0
Timestamp: 2025-08-17T08:55:30.118Z
Learning: Applies to crates/biome_html_formatter/benches/html_formatter.rs : Maintain the HTML formatter benchmark at benches/html_formatter.rs within the biome_html_formatter crate

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_js_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:48:52.001Z
Learning: Applies to crates/biome_js_formatter/**/*.rs : Use dbg_write! to debug and inspect the written IR elements during formatter development

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_service/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:53:15.299Z
Learning: Applies to crates/biome_service/src/workspace_watcher.rs : Keep workspace state in sync with the filesystem using WorkspaceWatcher; only active in daemon mode

crates/biome_html_syntax/src/attr_ext.rs (2)

6-15: Don’t mask token failures as empty strings

Returning Some(Text::default()) on token extraction failure can misclassify the attribute (e.g. treat an error as an unsupported type). Propagate None instead.

-            Self::HtmlString(string) => Some(
-                string
-                    .value_token()
-                    .map(|token| inner_string_text(&token).into())
-                    .unwrap_or_default(),
-            ),
+            Self::HtmlString(string) => {
+                string
+                    .value_token()
+                    .ok()
+                    .map(|token| inner_string_text(&token).into())
+            }

---

6-16: Consider returning a borrowed view to avoid allocation

If this ends up hot, a TokenText (or Cow<str>) variant would avoid allocating a fresh Text. Alternatively, offer a second method returning a borrowed view.

crates/biome_html_syntax/src/element_ext.rs (2)

101-122: Normalise type values before mapping (and pass as &str explicitly)

Some authors include MIME parameters (e.g. application/json; charset=utf-8). Normalise before mapping, and pass &str explicitly to avoid relying on implicit coercions.

-        let script_type = self
+        let script_type = self
             .find_attribute_by_name("type")
             .and_then(|attribute| {
                 let initializer = attribute.initializer()?;
-                let value = initializer.value().ok()?.string_value()?;
-                Some(ScriptType::from_type_value(&value))
+                let value = initializer.value().ok()?.string_value()?;
+                let value = value.as_str();
+                let type_value = value.split(';').next().unwrap_or(value);
+                Some(ScriptType::from_type_value(type_value))
             })
             .unwrap_or_default();

Note: If string_value() is changed to propagate None on token errors (suggested in attr_ext.rs), this will also avoid misclassifying error cases.

---

124-135: Style tags: consider guarding by type in future

Today any <style> returns true. If you later support non‑CSS type values (e.g. type="text/x-less"), you may want to gate this similarly to scripts.

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:48:27.774Z
Learning: Applies to crates/biome_formatter/biome_html_formatter/src/cst.rs : Define FormatHtmlSyntaxNode in cst.rs and implement FormatRule<HtmlSyntaxNode>, plus AsFormat and IntoFormat for HtmlSyntaxNode using the provided mapping code

crates/biome_service/src/file_handlers/html.rs (5)

300-314: Minor readability: use match for script type to file source mapping.

A small tidy-up makes the intent crisper.

Apply this diff:

-    let file_source = if script_type.is_javascript_module() {
-        JsFileSource::js_module()
-    } else if script_type.is_javascript() {
-        JsFileSource::js_script()
-    } else {
-        return None;
-    };
+    let file_source = match () {
+        _ if script_type.is_javascript_module() => JsFileSource::js_module(),
+        _ if script_type.is_javascript() => JsFileSource::js_script(),
+        _ => return None,
+    };

---

345-378: JSON embedding: confirm MIME coverage and call-site gating.

• Do we also want to support application/ld+json? It’s commonly used for structured data and is JSON.
• As with JS, please confirm callers only route supported <script type="application/json" | "importmap"> here.

If you want, I can add script-type checks (or extend ScriptType) and corresponding tests for ld+json/importmap.

---

469-472: Lookup is O(n) per embed; pre-index by range to avoid quadratic scans.

Likely fine for small n, but cheap to improve.

Apply this diff to the closure:

-    formatted.format_embedded(move |range| {
-        let mut iter = embedded_nodes.iter();
-        let node = iter.find(|node| node.range == range)?;
+    formatted.format_embedded(move |range| {
+        let node = by_range.get(&range)?;

And add this initialisation just above the closure:

let by_range: std::collections::HashMap<_, _> =
    embedded_nodes.iter().map(|n| (n.range, n)).collect();

If TextRange isn’t Hash, switch to BTreeMap.

---

473-492: Potential extra blank line before embedded content.

Two Hard line breaks before the content likely insert a blank line. Trim one for tighter output.

Apply this diff:

-            if indent_script_and_style {
-                let elements = vec![
-                    FormatElement::Line(LineMode::Hard),
-                    FormatElement::Tag(Tag::StartIndent),
-                    FormatElement::Line(LineMode::Hard),
-                    FormatElement::Interned(Interned::new(document.into_elements())),
-                    FormatElement::Tag(Tag::EndIndent),
-                ];
-                Document::new(elements)
-            } else {
+            if indent_script_and_style {
+                let elements = vec![
+                    FormatElement::Line(LineMode::Hard),
+                    FormatElement::Tag(Tag::StartIndent),
+                    FormatElement::Interned(Interned::new(document.into_elements())),
+                    FormatElement::Tag(Tag::EndIndent),
+                ];
+                Document::new(elements)
+            } else {

Please sanity-check with the new HTML+JSON test to ensure no unintended spacing changes.

---

496-515: Avoid shadowing node for clarity in each branch.

Rename the inner node binding to reduce cognitive load.

Apply these diffs:

@@
-                let node = node.node.root.clone().into_node::<JsLanguage>();
-                let formatted =
-                    biome_js_formatter::format_node_with_offset(js_options, &node).ok()?;
+                let embedded = node.node.root.clone().into_node::<JsLanguage>();
+                let formatted =
+                    biome_js_formatter::format_node_with_offset(js_options, &embedded).ok()?;
@@
-                let node = node.node.root.clone().into_node::<JsonLanguage>();
-                let formatted =
-                    biome_json_formatter::format_node_with_offset(json_options, &node).ok()?;
+                let embedded = node.node.root.clone().into_node::<JsonLanguage>();
+                let formatted =
+                    biome_json_formatter::format_node_with_offset(json_options, &embedded).ok()?;
@@
-                let node = node.node.root.clone().into_node::<CssLanguage>();
-                let formatted =
-                    biome_css_formatter::format_node_with_offset(css_options, &node).ok()?;
+                let embedded = node.node.root.clone().into_node::<CssLanguage>();
+                let formatted =
+                    biome_css_formatter::format_node_with_offset(css_options, &embedded).ok()?;

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Learnt from: arendjr
PR: biomejs/biome#7571
File: crates/biome_service/src/file_handlers/html.rs:360-368
Timestamp: 2025-09-23T21:33:00.819Z
Learning: Don't flag potential move/borrow issues in Rust code reviews since the Rust compiler catches these at compile time. Focus on logic, design, and issues that the toolchain doesn't automatically detect.

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:48:27.774Z
Learning: Applies to crates/biome_formatter/biome_html_formatter/src/lib.rs : Expose a documented public function format_node(options: HtmlFormatOptions, root: &HtmlSyntaxNode) -> FormatResult<Formatted<HtmlFormatContext>> delegating to biome_formatter::format_node

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_js_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:48:52.001Z
Learning: Applies to crates/biome_js_formatter/**/*.rs : Import the FormatNode trait and implement it for your Node

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:48:27.774Z
Learning: Applies to crates/biome_formatter/biome_html_formatter/src/cst.rs : Define FormatHtmlSyntaxNode in cst.rs and implement FormatRule<HtmlSyntaxNode>, plus AsFormat and IntoFormat for HtmlSyntaxNode using the provided mapping code

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_js_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:48:52.001Z
Learning: Applies to crates/biome_js_formatter/**/*.rs : Use the generic Format trait and FormatNode for AST nodes when implementing the formatter