Reviewing files that changed from the base of the PR and between c294644 and 654b64b.

• crates/biome_diagnostics_categories/src/categories.rs is excluded by !**/categories.rs and included by **
• crates/biome_js_analyze/tests/specs/source/useSortedInterfaceMembers/mixed.ts.snap is excluded by !**/*.snap and included by **
• crates/biome_js_analyze/tests/specs/source/useSortedInterfaceMembers/sorted.ts.snap is excluded by !**/*.snap and included by **
• crates/biome_js_analyze/tests/specs/source/useSortedInterfaceMembers/unsorted.ts.snap is excluded by !**/*.snap and included by **
• packages/@biomejs/backend-jsonrpc/src/workspace.ts is excluded by !**/backend-jsonrpc/src/workspace.ts and included by **
• packages/@biomejs/biome/configuration_schema.json is excluded by !**/configuration_schema.json and included by **

• crates/biome_configuration/src/analyzer/assist/actions.rs (9 hunks)
• crates/biome_js_analyze/src/assist/source.rs (1 hunks)
• crates/biome_js_analyze/src/assist/source/use_sorted_interface_members.rs (1 hunks)
• crates/biome_js_analyze/src/options.rs (1 hunks)
• crates/biome_js_analyze/tests/specs/source/useSortedInterfaceMembers/mixed.ts (1 hunks)
• crates/biome_js_analyze/tests/specs/source/useSortedInterfaceMembers/sorted.ts (1 hunks)
• crates/biome_js_analyze/tests/specs/source/useSortedInterfaceMembers/unsorted.ts (1 hunks)
• crates/biome_rule_options/src/lib.rs (1 hunks)
• crates/biome_rule_options/src/use_sorted_interface_members.rs (1 hunks)

• GitHub Check: Bench (biome_package)
• GitHub Check: Bench (biome_configuration)
• GitHub Check: Check JS Files
• GitHub Check: autofix
• GitHub Check: Bench (biome_html_formatter)
• GitHub Check: Bench (biome_css_formatter)
• GitHub Check: Bench (biome_html_parser)
• GitHub Check: Bench (biome_graphql_formatter)
• GitHub Check: Bench (biome_module_graph)
• GitHub Check: Bench (biome_json_parser)
• GitHub Check: Bench (biome_json_analyze)
• GitHub Check: Bench (biome_graphql_parser)
• GitHub Check: Bench (biome_json_formatter)
• GitHub Check: Bench (biome_css_analyze)
• GitHub Check: Bench (biome_css_parser)
• GitHub Check: Bench (biome_js_parser)
• GitHub Check: Bench (biome_js_analyze)
• GitHub Check: Bench (biome_js_formatter)
• GitHub Check: Test Node.js API
• GitHub Check: Documentation
• GitHub Check: Check Dependencies
• GitHub Check: Lint project (depot-windows-2022)
• GitHub Check: Test (depot-ubuntu-24.04-arm-16)
• GitHub Check: Test (depot-windows-2022-16)
• GitHub Check: Lint project (depot-ubuntu-24.04-arm-16)

crates/biome_js_analyze/src/options.rs (1)

453-454: Alias slots in nicely.
Thanks for threading the new assist into the generated aliases without rocking the alphabetical boat.

crates/biome_js_analyze/src/assist/source/use_sorted_interface_members.rs (3)

20-38: Replace single‑use trait with a simple helper that returns Option<_>

A trait implemented for a single type adds indirection. A small function with .ok() is clearer.

Apply this diff:

-trait TsTypeMemberName {
-    fn name(&self) -> SyntaxResult<Option<AnyJsObjectMemberName>>;
-}
-impl TsTypeMemberName for AnyTsTypeMember {
-    fn name(&self) -> SyntaxResult<Option<AnyJsObjectMemberName>> {
-        match self {
-            // Property signatures have names
-            Self::TsPropertySignatureTypeMember(prop) => prop.name().map(Some),
-            // Method signatures have names
-            Self::TsMethodSignatureTypeMember(method) => method.name().map(Some),
-            // Getter signatures have names
-            Self::TsGetterSignatureTypeMember(getter) => getter.name().map(Some),
-            // Setter signatures have names
-            Self::TsSetterSignatureTypeMember(setter) => setter.name().map(Some),
-            // Call signatures, construct signatures, and index signatures don't have sortable names
-            _ => Ok(None),
-        }
-    }
-}
+fn type_member_name(member: &AnyTsTypeMember) -> Option<AnyJsObjectMemberName> {
+    match member {
+        AnyTsTypeMember::TsPropertySignatureTypeMember(prop) => prop.name().ok(),
+        AnyTsTypeMember::TsMethodSignatureTypeMember(method) => method.name().ok(),
+        AnyTsTypeMember::TsGetterSignatureTypeMember(getter) => getter.name().ok(),
+        AnyTsTypeMember::TsSetterSignatureTypeMember(setter) => setter.name().ok(),
+        // Call, construct, and index signatures have no sortable name
+        _ => None,
+    }
+}

---

70-97: Don’t move non‑sortable members; perform an in‑place stable reorder

Current fix moves non‑sortable members to the end, contradicting the intent that they’re “non‑sortable”, and mismatches detection (which ignores their positions). Keep them in place and only reorder sortable slots.

Apply this diff:

-    let mut sortable_members = Vec::new();
-    let mut non_sortable_members = Vec::new();
-
-    // Separate sortable from non-sortable members
-    for member in list.iter() {
-        if let Ok(Some(name)) = member.name() {
-            if let Some(token_text) = name.name() {
-                sortable_members.push((member, ComparableToken::new(token_text)));
-            } else {
-                // Name exists but is not sortable (computed/dynamic)
-                non_sortable_members.push(member);
-            }
-        } else {
-            // No name (call signatures, construct signatures, index signatures)
-            non_sortable_members.push(member);
-        }
-    }
-
-    // Sort the sortable members
-    sortable_members.sort_by(|(_, a), (_, b)| comparator(a, b));
-
-    // Combine: all sortable members first, then all non-sortable members
-    let mut new_members: Vec<AnyTsTypeMember> = sortable_members
-        .into_iter()
-        .map(|(member, _)| member)
-        .collect();
-
-    new_members.extend(non_sortable_members);
-
-    make::ts_type_member_list(new_members)
+    // Collect sortable members and mark which positions are sortable
+    let mut sortable: Vec<(AnyTsTypeMember, ComparableToken)> = Vec::new();
+    let mut is_sortable: Vec<bool> = Vec::new();
+    for member in list.iter() {
+        if let Some(name) = type_member_name(&member)
+            && let Some(token) = name.name()
+        {
+            is_sortable.push(true);
+            sortable.push((member, ComparableToken::new(token)));
+        } else {
+            is_sortable.push(false);
+        }
+    }
+
+    // Sort only the sortable members by the chosen comparator
+    sortable.sort_by(|(_, a), (_, b)| comparator(a, b));
+    let mut sorted_iter = sortable.into_iter().map(|(m, _)| m);
+
+    // Rebuild the list: keep non-sortables in place, fill sortable slots with the next sorted member
+    let new_members: Vec<AnyTsTypeMember> = list
+        .iter()
+        .enumerate()
+        .map(|(idx, member)| if is_sortable[idx] {
+            sorted_iter.next().expect("sorted members length should match")
+        } else {
+            member
+        })
+        .collect();
+
+    make::ts_type_member_list(new_members)

If you prefer grouping non‑sortables at the end, then update the detection to also assert “non‑sortables are trailing”, so run() and the fix stay consistent.

---

135-135: Set version: "next" for new rules

New or updated rules should use version: "next".

Apply this diff:

-        version: "2.0.0",
+        version: "next",

As per coding guidelines

crates/biome_rule_options/src/use_sorted_interface_members.rs (1)

1-6: Add the missing sort_order option (and wire it into the rule)

The options struct is empty but the rule reads options.sort_order via UseSortedKeysOptions. Either alias to that type or add the field here and update the rule to use this options type. Below adds the field and keeps derives consistent.

Apply this diff:

 use biome_deserialize_macros::Deserializable;
 use serde::{Deserialize, Serialize};
+use crate::use_sorted_keys::SortOrder;
 #[derive(Default, Clone, Debug, Deserialize, Deserializable, Eq, PartialEq, Serialize)]
 #[cfg_attr(feature = "schema", derive(schemars::JsonSchema))]
 #[serde(rename_all = "camelCase", deny_unknown_fields, default)]
-pub struct UseSortedInterfaceMembersOptions {}
+pub struct UseSortedInterfaceMembersOptions {
+    pub sort_order: SortOrder,
+}

As per coding guidelines

crates/biome_configuration/src/analyzer/assist/actions.rs (1)

200-206: Looks consistent with the other assists.

Nice to see the new rule documented and threaded through the config in one sweep.

Reviewing files that changed from the base of the PR and between 654b64b and befa13a.

• crates/biome_diagnostics_categories/src/categories.rs is excluded by !**/categories.rs and included by **
• crates/biome_js_analyze/tests/specs/source/useSortedInterfaceMembers/multiple_non_sortable.ts.snap is excluded by !**/*.snap and included by **
• crates/biome_js_analyze/tests/specs/source/useSortedInterfaceMembers/sorted.ts.snap is excluded by !**/*.snap and included by **
• crates/biome_js_analyze/tests/specs/source/useSortedInterfaceMembers/unsorted.ts.snap is excluded by !**/*.snap and included by **

• crates/biome_js_analyze/src/assist/source.rs (1 hunks)
• crates/biome_js_analyze/src/assist/source/use_sorted_interface_members.rs (1 hunks)
• crates/biome_js_analyze/src/options.rs (1 hunks)
• crates/biome_js_analyze/tests/specs/source/useSortedInterfaceMembers/multiple_non_sortable.ts (1 hunks)
• crates/biome_js_analyze/tests/specs/source/useSortedInterfaceMembers/sorted.ts (1 hunks)
• crates/biome_js_analyze/tests/specs/source/useSortedInterfaceMembers/unsorted.ts (1 hunks)

• crates/biome_js_analyze/src/assist/source.rs
• crates/biome_js_analyze/tests/specs/source/useSortedInterfaceMembers/sorted.ts
• crates/biome_js_analyze/src/options.rs

• GitHub Check: Documentation
• GitHub Check: Lint project (depot-ubuntu-24.04-arm-16)
• GitHub Check: Test (depot-windows-2022-16)
• GitHub Check: Test (depot-ubuntu-24.04-arm-16)
• GitHub Check: Lint project (depot-windows-2022)
• GitHub Check: Check Dependencies
• GitHub Check: Bench (biome_package)
• GitHub Check: Bench (biome_configuration)
• GitHub Check: Bench (biome_graphql_formatter)
• GitHub Check: Bench (biome_module_graph)
• GitHub Check: Bench (biome_json_analyze)
• GitHub Check: Bench (biome_html_formatter)
• GitHub Check: Bench (biome_html_parser)
• GitHub Check: Bench (biome_graphql_parser)
• GitHub Check: Bench (biome_js_formatter)
• GitHub Check: Bench (biome_js_analyze)
• GitHub Check: Test Node.js API
• GitHub Check: Bench (biome_css_analyze)
• GitHub Check: Bench (biome_css_formatter)
• GitHub Check: Bench (biome_json_formatter)
• GitHub Check: Bench (biome_js_parser)
• GitHub Check: Bench (biome_json_parser)
• GitHub Check: Bench (biome_css_parser)
• GitHub Check: autofix

crates/biome_js_analyze/src/assist/source/use_sorted_interface_members.rs (2)

7-8: Fix the TextRange import

TextRange lives in biome_rowan; the current import won’t compile. Let’s pull it from the existing biome_rowan import bundle so the build stays happy.

-use biome_deserialize::TextRange;
-use biome_rowan::{AstNode, AstNodeList, BatchMutationExt};
+use biome_rowan::{AstNode, AstNodeList, BatchMutationExt, TextRange};

Also applies to: 15-15

---

116-121: Respect ctx.metadata().applicability()

Assists are expected to honour the analyser metadata, otherwise global applicability tweaks are ignored. Swapping out the hard-coded Applicability::Always keeps us in line with the other rules. Based on learnings

-            rule_action_category!(),
-            Applicability::Always,
+            rule_action_category!(),
+            ctx.metadata().applicability(),

crates/biome_js_analyze/tests/specs/source/useSortedInterfaceMembers/unsorted.ts (1)

1-5: LGTM: Unsorted fixture gives the rule something to chew on.

Leaving zebra ahead of apple nails the detection path—nicely done.

crates/biome_js_analyze/tests/specs/source/useSortedInterfaceMembers/multiple_non_sortable.ts (1)

1-11: LGTM: Mixed members thoroughly exercise the tricky cases.

This line-up keeps sortable bits and the call/construct/index signatures distinct, which is exactly what the fixer needs.

Reviewing files that changed from the base of the PR and between a837aed and 192a896.

• crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rs is excluded by !**/migrate/eslint_any_rule_to_biome.rs and included by **
• crates/biome_configuration/src/analyzer/linter/rules.rs is excluded by !**/rules.rs and included by **
• crates/biome_diagnostics_categories/src/categories.rs is excluded by !**/categories.rs and included by **
• crates/biome_js_analyze/src/lint/nursery.rs is excluded by !**/nursery.rs and included by **
• crates/biome_js_analyze/tests/specs/nursery/useSortedInterfaceMembers/multiple_non_sortable.ts.snap is excluded by !**/*.snap and included by **
• crates/biome_js_analyze/tests/specs/nursery/useSortedInterfaceMembers/sorted.ts.snap is excluded by !**/*.snap and included by **
• crates/biome_js_analyze/tests/specs/nursery/useSortedInterfaceMembers/unsorted.ts.snap is excluded by !**/*.snap and included by **
• packages/@biomejs/backend-jsonrpc/src/workspace.ts is excluded by !**/backend-jsonrpc/src/workspace.ts and included by **
• packages/@biomejs/biome/configuration_schema.json is excluded by !**/configuration_schema.json and included by **

• biome.json (1 hunks)
• crates/biome_js_analyze/src/lint/nursery/use_sorted_interface_members.rs (1 hunks)
• crates/biome_js_analyze/src/options.rs (1 hunks)
• crates/biome_js_analyze/tests/specs/nursery/useSortedInterfaceMembers/multiple_non_sortable.ts (1 hunks)
• crates/biome_js_analyze/tests/specs/nursery/useSortedInterfaceMembers/sorted.ts (1 hunks)
• crates/biome_js_analyze/tests/specs/nursery/useSortedInterfaceMembers/unsorted.ts (1 hunks)
• crates/biome_rule_options/src/lib.rs (1 hunks)
• crates/biome_rule_options/src/use_sorted_interface_members.rs (1 hunks)

• crates/biome_rule_options/src/lib.rs
• crates/biome_rule_options/src/use_sorted_interface_members.rs

• GitHub Check: Bench (biome_json_parser)
• GitHub Check: Bench (biome_html_formatter)
• GitHub Check: Bench (biome_configuration)
• GitHub Check: Bench (biome_html_parser)
• GitHub Check: Bench (biome_module_graph)
• GitHub Check: Bench (biome_package)
• GitHub Check: Bench (biome_css_analyze)
• GitHub Check: Bench (biome_json_formatter)
• GitHub Check: Bench (biome_graphql_formatter)
• GitHub Check: Bench (biome_graphql_parser)
• GitHub Check: Bench (biome_json_analyze)
• GitHub Check: Test (depot-windows-2022-16)
• GitHub Check: Bench (biome_css_parser)
• GitHub Check: Bench (biome_css_formatter)
• GitHub Check: Test (depot-ubuntu-24.04-arm-16)
• GitHub Check: autofix
• GitHub Check: Bench (biome_js_analyze)
• GitHub Check: Bench (biome_js_formatter)
• GitHub Check: Documentation
• GitHub Check: Bench (biome_js_parser)
• GitHub Check: Check Dependencies
• GitHub Check: Lint project (depot-ubuntu-24.04-arm-16)
• GitHub Check: Lint project (depot-windows-2022)
• GitHub Check: Test Node.js API
• GitHub Check: Check JS Files

crates/biome_js_analyze/src/options.rs (1)

453-454: LGTM: options alias wiring looks correct

Alias points to the rule’s Options and follows the established pattern.

crates/biome_js_analyze/src/lint/nursery/use_sorted_interface_members.rs (1)

7-7: Fix incorrect TextRange import (compile error)

Import TextRange from biome_rowan, not biome_deserialize.

Apply this diff:

- use biome_deserialize::TextRange;
+ use biome_rowan::TextRange;

biome.json (1)

79-82: Approve rule registration: useSortedInterfaceMembers correctly referenced
Config in biome.json contains a single reference matching the declare_lint_rule! name in use_sorted_interface_members.rs.

Reviewing files that changed from the base of the PR and between b554dd0 and 33c7e4d.

• crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rs is excluded by !**/migrate/eslint_any_rule_to_biome.rs and included by **
• crates/biome_configuration/src/analyzer/linter/rules.rs is excluded by !**/rules.rs and included by **
• crates/biome_diagnostics_categories/src/categories.rs is excluded by !**/categories.rs and included by **
• crates/biome_js_analyze/src/lint/nursery.rs is excluded by !**/nursery.rs and included by **
• crates/biome_js_analyze/tests/specs/nursery/useSortedInterfaceMembers/multiple_non_sortable.ts.snap is excluded by !**/*.snap and included by **
• crates/biome_js_analyze/tests/specs/nursery/useSortedInterfaceMembers/sortable_after_non_sortable.ts.snap is excluded by !**/*.snap and included by **
• crates/biome_js_analyze/tests/specs/nursery/useSortedInterfaceMembers/sorted.ts.snap is excluded by !**/*.snap and included by **
• crates/biome_js_analyze/tests/specs/nursery/useSortedInterfaceMembers/unsorted.ts.snap is excluded by !**/*.snap and included by **
• crates/biome_js_analyze/tests/specs/nursery/useSortedInterfaceMembers/with_comments.ts.snap is excluded by !**/*.snap and included by **
• packages/@biomejs/backend-jsonrpc/src/workspace.ts is excluded by !**/backend-jsonrpc/src/workspace.ts and included by **
• packages/@biomejs/biome/configuration_schema.json is excluded by !**/configuration_schema.json and included by **

• biome.json (1 hunks)
• crates/biome_js_analyze/src/lint/nursery/use_sorted_interface_members.rs (1 hunks)
• crates/biome_js_analyze/src/options.rs (1 hunks)
• crates/biome_js_analyze/tests/specs/nursery/useSortedInterfaceMembers/multiple_non_sortable.ts (1 hunks)
• crates/biome_js_analyze/tests/specs/nursery/useSortedInterfaceMembers/sortable_after_non_sortable.ts (1 hunks)
• crates/biome_js_analyze/tests/specs/nursery/useSortedInterfaceMembers/sorted.ts (1 hunks)
• crates/biome_js_analyze/tests/specs/nursery/useSortedInterfaceMembers/unsorted.ts (1 hunks)
• crates/biome_js_analyze/tests/specs/nursery/useSortedInterfaceMembers/with_comments.ts (1 hunks)
• crates/biome_rule_options/src/lib.rs (1 hunks)
• crates/biome_rule_options/src/use_sorted_interface_members.rs (1 hunks)

• crates/biome_js_analyze/src/options.rs
• biome.json
• crates/biome_rule_options/src/lib.rs
• crates/biome_js_analyze/tests/specs/nursery/useSortedInterfaceMembers/sorted.ts
• crates/biome_js_analyze/tests/specs/nursery/useSortedInterfaceMembers/unsorted.ts

• GitHub Check: Test (depot-windows-2022-16)
• GitHub Check: End-to-end tests
• GitHub Check: Test (depot-ubuntu-24.04-arm-16)
• GitHub Check: Lint project (depot-ubuntu-24.04-arm-16)
• GitHub Check: Lint project (depot-windows-2022)
• GitHub Check: Check Dependencies
• GitHub Check: Documentation
• GitHub Check: Check JS Files
• GitHub Check: Bench (biome_configuration)
• GitHub Check: Test Node.js API
• GitHub Check: Bench (biome_json_analyze)
• GitHub Check: Bench (biome_graphql_formatter)
• GitHub Check: Bench (biome_json_formatter)
• GitHub Check: Bench (biome_html_formatter)
• GitHub Check: Bench (biome_module_graph)
• GitHub Check: autofix
• GitHub Check: Bench (biome_html_parser)
• GitHub Check: Bench (biome_package)
• GitHub Check: Bench (biome_json_parser)
• GitHub Check: Bench (biome_graphql_parser)
• GitHub Check: Bench (biome_css_parser)
• GitHub Check: Bench (biome_css_analyze)
• GitHub Check: Bench (biome_css_formatter)
• GitHub Check: Bench (biome_js_formatter)
• GitHub Check: Bench (biome_js_analyze)
• GitHub Check: Bench (biome_js_parser)

crates/biome_js_analyze/src/lint/nursery/use_sorted_interface_members.rs (1)

8-15: Import TextRange from biome_rowan

Line 8 grabs TextRange from biome_deserialize, but that crate doesn’t export it—cargo will sulk at compile time. Bring it in from biome_rowan alongside the other rowan imports so the build stays happy.

-use biome_deserialize::TextRange;
-use biome_rowan::{AstNode, AstNodeList, BatchMutationExt};
+use biome_rowan::{AstNode, AstNodeList, BatchMutationExt, TextRange};

Reviewing files that changed from the base of the PR and between 3cbb585 and 4a2ab26.

• crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rs is excluded by !**/migrate/eslint_any_rule_to_biome.rs and included by **
• crates/biome_configuration/src/analyzer/linter/rules.rs is excluded by !**/rules.rs and included by **
• crates/biome_diagnostics_categories/src/categories.rs is excluded by !**/categories.rs and included by **
• crates/biome_js_analyze/src/lint/nursery.rs is excluded by !**/nursery.rs and included by **
• crates/biome_js_analyze/tests/specs/nursery/useSortedInterfaceMembers/multiple_non_sortable.ts.snap is excluded by !**/*.snap and included by **
• crates/biome_js_analyze/tests/specs/nursery/useSortedInterfaceMembers/sortable_after_non_sortable.ts.snap is excluded by !**/*.snap and included by **
• crates/biome_js_analyze/tests/specs/nursery/useSortedInterfaceMembers/sorted.ts.snap is excluded by !**/*.snap and included by **
• crates/biome_js_analyze/tests/specs/nursery/useSortedInterfaceMembers/unsorted.ts.snap is excluded by !**/*.snap and included by **
• crates/biome_js_analyze/tests/specs/nursery/useSortedInterfaceMembers/with_comments.ts.snap is excluded by !**/*.snap and included by **
• packages/@biomejs/backend-jsonrpc/src/workspace.ts is excluded by !**/backend-jsonrpc/src/workspace.ts and included by **
• packages/@biomejs/biome/configuration_schema.json is excluded by !**/configuration_schema.json and included by **

• biome.json (1 hunks)
• crates/biome_js_analyze/src/lint/nursery/use_sorted_interface_members.rs (1 hunks)
• crates/biome_js_analyze/src/options.rs (1 hunks)
• crates/biome_js_analyze/tests/specs/nursery/useSortedInterfaceMembers/multiple_non_sortable.ts (1 hunks)
• crates/biome_js_analyze/tests/specs/nursery/useSortedInterfaceMembers/sortable_after_non_sortable.ts (1 hunks)
• crates/biome_js_analyze/tests/specs/nursery/useSortedInterfaceMembers/sorted.ts (1 hunks)
• crates/biome_js_analyze/tests/specs/nursery/useSortedInterfaceMembers/unsorted.ts (1 hunks)
• crates/biome_js_analyze/tests/specs/nursery/useSortedInterfaceMembers/with_comments.ts (1 hunks)
• crates/biome_rule_options/src/lib.rs (1 hunks)
• crates/biome_rule_options/src/use_sorted_interface_members.rs (1 hunks)
• packages/@biomejs/backend-jsonrpc/src/transport.ts (3 hunks)
• packages/@biomejs/js-api/src/wasm.ts (1 hunks)
• scripts/version-check.ts (3 hunks)

• crates/biome_rule_options/src/use_sorted_interface_members.rs
• crates/biome_js_analyze/tests/specs/nursery/useSortedInterfaceMembers/unsorted.ts
• biome.json
• crates/biome_js_analyze/tests/specs/nursery/useSortedInterfaceMembers/with_comments.ts
• crates/biome_js_analyze/src/options.rs

• GitHub Check: Test Node.js API
• GitHub Check: Bench (biome_js_parser)
• GitHub Check: Bench (biome_js_analyze)
• GitHub Check: Bench (biome_js_formatter)
• GitHub Check: autofix
• GitHub Check: Bench (biome_configuration)
• GitHub Check: Test (depot-ubuntu-24.04-arm-16)
• GitHub Check: Test (depot-windows-2022-16)
• GitHub Check: Documentation
• GitHub Check: Check Dependencies
• GitHub Check: Lint project (depot-ubuntu-24.04-arm-16)
• GitHub Check: Check JS Files
• GitHub Check: Lint project (depot-windows-2022)

packages/@biomejs/js-api/src/wasm.ts (1)

87-117: LGTM! Alphabetical ordering applied correctly.

All three interfaces (DiagnosticPrinter, Workspace, and Module) now follow alphabetical member ordering, consistent with the new useSortedInterfaceMembers rule being introduced in this PR.

crates/biome_js_analyze/tests/specs/nursery/useSortedInterfaceMembers/sortable_after_non_sortable.ts (1)

1-7: LGTM!

The test fixture correctly exercises the sortable-after-non-sortable constraint. The interface design is spot-on for validating the rule's behaviour.

packages/@biomejs/backend-jsonrpc/src/transport.ts (4)

2-2: Verify this change belongs in this PR.

The addition of destroy(): void to the Socket interface appears unrelated to sorting interface members. Is this intended to be part of this PR?

---

15-15: Kind discriminants added for tagged unions.

Adding readonly kind fields establishes proper discriminated unions for ReaderState, which is good practice. However, this appears orthogonal to the UseSortedInterfaceMembers rule.

Are these changes intended for this PR or should they be in a separate PR?

Also applies to: 21-21

---

28-28: Verify jsonrpc version field belongs in this PR.

Explicit jsonrpc: "2.0" field added. This change appears unrelated to sorting interface members.

---

95-96: Method reordering demonstrates the lint rule in action.

The PendingRequest interface now has reject before resolve, which is alphabetically correct. If intentional, this nicely demonstrates the rule's behaviour. However, verify this reordering is intentional and won't break existing code that depends on member order (though TypeScript interfaces shouldn't be order-dependent at runtime).

crates/biome_js_analyze/tests/specs/nursery/useSortedInterfaceMembers/sorted.ts (1)

1-6: LGTM!

Clean test fixture for the already-sorted case. All members are sortable and correctly ordered alphabetically.

crates/biome_js_analyze/tests/specs/nursery/useSortedInterfaceMembers/multiple_non_sortable.ts (1)

1-11: LGTM!

Excellent test fixture exercising multiple non-sortable member types interleaved with sortable ones. This covers the complex scenario comprehensively.

crates/biome_js_analyze/src/lint/nursery/use_sorted_interface_members.rs (7)

16-76: Rule declaration and documentation are clear.

The declare_lint_rule! macro is properly structured with comprehensive documentation explaining sortable vs non-sortable members and expected behaviour.

---

77-92: Detection logic delegates to helper.

The run method correctly uses is_interface_members_sorted with the ASCII natural comparator.

---

93-103: Diagnostic message is clear.

Simple, direct message about unsorted members.

---

105-119: Fix generation uses correct applicability.

The action method now correctly uses ctx.metadata().applicability() rather than hard-coded Applicability::Always. Well done addressing the previous review comment.

---

124-134: Member name extraction handles all sortable types.

The get_type_member_name function correctly identifies sortable members (property, method, getter, setter) and returns None for non-sortable members (call, construct, index signatures).

---

135-169: Detection correctly enforces sortable-first constraint.

The is_interface_members_sorted function now properly tracks whether a non-sortable member has been seen and returns false if any sortable member appears after a non-sortable one. This addresses the previous detection gap. The logic is sound:

1. Maintains previous key for order checking
2. Flags sortable-after-non-sortable as unsorted
3. Checks alphabetical order among sortable members
4. Marks non-sortable members seen

---

170-204: Sorting implementation separates and orders correctly.

The sort_interface_members function:

1. Separates sortable from non-sortable members
2. Sorts sortable members alphabetically
3. Concatenates sorted sortable members first, then non-sortable in original order

This matches the documented behaviour perfectly.

crates/biome_rule_options/src/lib.rs (1)

347-347: Manual codegen verification required. The sandbox couldn’t run xtask codegen. Please run locally in crates/biome_rule_options:

cargo run --bin xtask codegen
git diff --exit-code src/lib.rs

and confirm src/use_sorted_interface_members.rs exists.

scripts/version-check.ts (2)

239-241: Field reordering looks fine.

The alphabetical ordering of interface members is consistent with the PR's goal to sort interface members.

---

336-337: Field reordering is appropriate.

The repositioning of these fields aligns with the interface member sorting objective.

Also applies to: 342-342, 348-348