crates/biome_js_analyze/src/react.rs (2)

136-141: Naming consistency: drop the get_ prefix.

Other accessors are import_names() / global_name(). Prefer import_aliases() for symmetry and update the call site.

Apply:

-    pub const fn get_import_aliases(self) -> &'static [&'static str] {
+    pub const fn import_aliases(self) -> &'static [&'static str] {
         match self {
             Self::React => &["@rbxts/react"],
             Self::ReactDOM => &[],
         }
     }

And:

-            lib.import_names().contains(&source_text)
-                || lib.get_import_aliases().contains(&source_text)
+            lib.import_names().contains(&source_text)
+                || lib.import_aliases().contains(&source_text)

Also applies to: 334-338

---

271-277: Consider applying aliases across all import checks, not just “global” detection.

Right now is_react_export/is_named_react_export only consider import_names(). If a project uses @rbxts/react, cases like React.createElement or named React exports may still be missed.

Optional patch to use aliases too:

 fn is_react_export(binding: &Binding, lib: ReactLibrary) -> bool {
   binding
     .syntax()
     .ancestors()
     .find_map(|ancestor| JsImport::cast(ancestor)?.source_text().ok())
-    .is_some_and(|source| lib.import_names().contains(&source.text()))
+    .is_some_and(|source| {
+        let t = source.text();
+        lib.import_names().contains(&t) || lib.import_aliases().contains(&t)
+    })
 }

 fn is_named_react_export(binding: &Binding, lib: ReactLibrary, name: &str) -> Option<bool> {
   …
   import
     .source_text()
     .ok()
-    .map(|import_name| lib.import_names().contains(&import_name.text()))
+    .map(|import_name| {
+        let t = import_name.text();
+        lib.import_names().contains(&t) || lib.import_aliases().contains(&t)
+    })
 }

Sanity-check request:

• Do @rbxts/react users rely on React.createElement/named exports? If yes, the above avoids surprising gaps.
• I can add focused tests for:
  • import React from "@rbxts/react"
  • import * as React from "@rbxts/react"
  • import { Fragment as F } from "@rbxts/react" (if supported)

Also applies to: 279-301

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro