crates/biome_cli/tests/cases/included_files.rs (1)

132-167: Make directory intent explicit in the glob.

Prefer !!test/** (or !!**/test/**) over !!test to unambiguously force-ignore the directory and all descendants across platforms.

Apply this diff:

-        r#"{ "files": { "includes": ["*.js", "!!test"] } }"#.as_bytes(),
+        r#"{ "files": { "includes": ["*.js", "!!test/**"] } }"#.as_bytes(),

.changeset/forced-files-forget.md (3)

9-9: Grammar/punctuation: clarify the sentence.

Add a missing comma and tweak phrasing for readability.

Apply this diff:

-The effect of force-ignoring is that the scanner will not index files matching the glob, even in project mode and those files are imported by other files.
+The effect of force-ignoring is that the scanner will not index files matching the glob, even in project mode, and even if those files are imported by other files.

---

33-41: Tighten prose and consistency.

• Use “outside” instead of “outside of”.
• End bullet sentences with a period for consistency.

Apply this diff:

- - Files inside a `generated` folder are not processed by the linter, but they will get indexed _if_ a file outside of a `generated` folder imports them.
+ - Files inside a `generated` folder are not processed by the linter, but they will get indexed _if_ a file outside a `generated` folder imports them.

And please add trailing periods to the other bullets in this list.

---

1-3: Confirm package list in the changeset.

This change spans multiple crates (glob, service, CLI, configuration, module_graph). Ensure all affected packages are listed in the front‑matter, or split into multiple changesets as appropriate.

Happy to generate a draft changeset enumerating crates touched by this PR if you want.

crates/biome_glob/src/lib.rs (5)

253-262: Document negated() behaviour for force-negated inputs.

Currently negated() maps ForceNegated -> Normal. Callers may expect a full toggle; make it explicit in the docs.

Apply this diff to the doc comment:

 /// Returns the negated version of this glob.
 ///
 /// ```
 /// let glob = "!*.js".parse::<biome_glob::Glob>().unwrap();
 /// assert!(!glob.negated().is_negated());
 ///
 /// let glob = "*.js".parse::<biome_glob::Glob>().unwrap();
 /// assert!(glob.negated().is_negated());
 /// ```
+/// Note: calling this on a force‑negated glob (`!!…`) clears negation and returns a normal glob.

---

302-306: Display renders the correct !/!! prefix. Add a test for !!.

Add a quick assertion in test_to_string to lock this in.

Add to test_to_string():

assert_eq!(Glob::from_str("!!**/*.rs").unwrap().to_string(), "!!**/*.rs");

---

318-343: Triple ! inputs.

"!!!*.js" becomes ForceNegated("!*.js"). That’s fine, but worth a test to avoid surprises.

Add a unit test:

assert!(Glob::from_str("!!!*.js").unwrap().is_force_negated());
assert_eq!(Glob::from_str("!!!*.js").unwrap().to_string(), "!!!*.js");

---

524-565: matches_forced_negation logic looks right. Add focused tests.

Add unit tests to cover:

• Forced‑negated overridden by later include.
• No match defaults to false.

Example tests:

#[test]
fn test_matches_forced_negation() {
    let globs = &[
        Glob::from_str("**").unwrap(),
        Glob::from_str("!!a*").unwrap(),
        Glob::from_str("a").unwrap(),
    ];
    assert!(CandidatePath::new(&"abc").matches_forced_negation(globs));
    assert!(!CandidatePath::new(&"a").matches_forced_negation(globs));
    assert!(!CandidatePath::new(&"b").matches_forced_negation(globs));
}

---

207-210: Update crate-level docs to mention !! force-negation.

Top-of-file docs still only describe !. Please add a short section for !! and fix the minor typo on Line 28 (“pat” → “path”).

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_service/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:53:15.299Z
Learning: Applies to crates/biome_service/src/workspace.rs : Implement the Workspace trait in src/workspace.rs

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_service/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:53:15.299Z
Learning: Applies to crates/biome_service/src/workspace/watcher.tests.rs : Place watcher tests for workspace methods in src/workspace/watcher.tests.rs

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_service/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:53:15.299Z
Learning: Applies to crates/biome_service/src/workspace/server.rs : Use WorkspaceServer (src/workspace/server.rs) to maintain workspace state in daemon and CLI daemonless modes

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_service/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:53:15.299Z
Learning: Applies to crates/biome_service/src/workspace_watcher.rs : Keep workspace state in sync with the filesystem using WorkspaceWatcher; only active in daemon mode

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2025-08-17T08:56:30.831Z
Learning: Applies to crates/biome_analyze/crates/biome_js_analyze/tests/quick_test.rs : Use `biome_js_analyze/tests/quick_test.rs` for quick, ad-hoc testing; un-ignore the test and adjust the rule filter as needed

Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:48:27.774Z
Learning: Applies to crates/biome_formatter/biome_html_formatter/tests/spec_test.rs : Create tests/spec_test.rs implementing the run(spec_input_file, _expected_file, test_directory, _file_type) function as shown and include!("language.rs")

.changeset/forced-files-forget.md (2)

35-38: Tighten sentence endings in bullets.

Guidelines ask every sentence to end with a period. Lines 35 and 37 end with a colon; consider converting those to full sentences.

- Because the [project domain](https://biomejs.dev/linter/domains/#project) is enabled, all supported files in the project are indexed _and_ processed by the linter, _except_:
+ Because the [project domain](https://biomejs.dev/linter/domains/#project) is enabled, all supported files in the project are indexed and processed by the linter, except for the cases below.
@@
- Files inside a `dist` folder are never indexed nor processed, not even if they are imported for any purpose, _except_:
+ Files inside a `dist` folder are never indexed nor processed, not even if they are imported for any purpose. The only exception is described below.

---

11-31: Add a Migration section with before/after config.

Helps users run through “what changed” quickly and aligns with comments asking for a migration. Keep headers at level 4 per guidelines.

 #### Example
+
+#### Migration
+
+Before (using `files.experimentalScannerIgnores`):
+
+```json
+{
+  "files": {
+    "experimentalScannerIgnores": [".cache", "dist"]
+  }
+}
+```
+
+After (using `files.includes` with force-ignore):
+
+```json
+{
+  "files": {
+    "includes": ["**", "!!**/dist"]
+  }
+}
+```
+
+Run `biome migrate` to update existing configs automatically.

crates/biome_configuration/src/lib.rs (2)

564-572: Link clarity for deprecation notice.

The docs anchor is correct; consider adding a brief “Use !! to force-ignore, ! to ignore” sentence in the diagnostic to reduce click-through.

-    /// **Deprecated:** Please use _force-ignore syntax_ in `files.includes`
-    /// instead: https://biomejs.dev/reference/configuration/#filesincludes
+    /// **Deprecated:** Use the _force-ignore_ syntax in `files.includes` instead
+    /// (https://biomejs.dev/reference/configuration/#filesincludes). Use `!!` to
+    /// force-ignore and `!` to ignore.

---

643-674: Edge-cases for suggestions.

If a user had entries with slashes or glob meta (e.g. tmp/cache or *.cache), the suggested "!!**/{entry}" may be misleading. Consider ignoring entries containing /, *, {, }, [, ], or ? or quoting them differently in the note.

-                            .map(|entry| format!("\"!!**/{entry}\""))
+                            .filter(|entry| !entry.chars().any(|c| matches!(c, '/' | '*' | '{' | '}' | '[' | ']' | '?')))
+                            .map(|entry| format!("\"!!**/{entry}\""))

crates/biome_glob/src/lib.rs (4)

228-243: Public API: expose force-negation clearly.

is_force_negated is helpful. Consider whether the method should live on NormalizedGlob as well for parity (tiny convenience).

---

253-261: Behaviour of negated() with force-negated inputs.

Calling negated() on a force-negated glob returns a normal glob (i.e. removes both negations). That’s reasonable, but please add a doc sentence to set expectations explicitly.

     /// Returns the negated version of this glob.
     ///
@@
     /// ```
     pub fn negated(self) -> Self {

Add:

+    /// Note: If this glob is force-negated (`!!`), calling `negated()` returns
+    /// a non-negated glob (it removes the forced negation).

---

317-344: Triple-bang inputs like !!!foo.

Parser treats !! as force-negation and the remaining ! as part of the pattern. This is likely fine; please add a small test asserting the intended behaviour so it doesn’t regress.

+    #[test]
+    fn test_triple_bang() {
+        let g = Glob::from_str("!!!foo").unwrap();
+        assert!(g.is_force_negated());
+        // Remaining '!' is literal; won't match "foo".
+        assert!(!g.is_match("foo"));
+        assert!(g.is_match("!foo"));
+    }

---

524-565: Semantics: can ! undo a prior !!?

matches_forced_negation returns the negation status of the last matching glob. That means a later !pattern will undo a prior !!pattern. The doc comment only mentions “undone by a later include”. If last-match-wins is the intended rule, update the doc. If “only includes undo force-negation” is intended, tweak the logic to skip non-forced negations when searching backwards and add tests for both cases.

Possible implementation if we want “only includes undo”:

-        for glob in globs.into_iter().rev() {
-            if glob.as_ref().is_raw_match_candidate(self) {
-                return glob.as_ref().is_force_negated();
-            }
-        }
+        let mut seen_force = false;
+        for glob in globs.into_iter().rev() {
+            let g = glob.as_ref();
+            if g.is_raw_match_candidate(self) {
+                if g.is_force_negated() {
+                    seen_force = true;
+                } else {
+                    // only a non-negated (include) clears forced status
+                    return !g.is_negated() && seen_force && false;
+                }
+            }
+        }
+        if seen_force { true } else { false }

…and add tests for ["*", "!!a*", "!a*"] to lock behaviour.

crates/biome_service/src/projects.rs (3)

128-155: Backward-compat check for deprecated scanner ignores.

Nice to keep a compatibility path. Please add a TODO with a version or milestone to remove this branch once the deprecation period ends.

-        // Deprecated: Check `experimentalScannerIgnores` too.
+        // Deprecated: Check `experimentalScannerIgnores` too.
+        // TODO: Remove after <target version> once migration has been available for a full cycle.

---

146-155: Nested vs root includes selection.

The “first nested project that prefixes the path” heuristic is fine; consider documenting that the closest (longest prefix) wins if multiple nested configs exist. Alternatively, pick the longest prefix explicitly.

-        let includes = project_data
-            .nested_settings
-            .iter()
-            .find(|(project_path, _)| path.starts_with(project_path))
+        let includes = project_data
+            .nested_settings
+            .iter()
+            .max_by_key(|(project_path, _)| if path.starts_with(project_path) { project_path.as_str().len() } else { 0 })
+            .filter(|(project_path, _)| path.starts_with(project_path))
             .map_or(
                 &project_data.root_settings.files.includes,
                 |(_, settings)| &settings.files.includes,
             );

---

198-236: Force-ignore vs inclusion in feature resolution.

get_file_features checks includes.is_included(path) but not Projects::is_force_ignored. If the server already gates indexing earlier via is_force_ignored, all good; otherwise, consider early-out here to treat force-ignored files as ignored for all features.

-        } else if !settings.files.includes.is_included(path)
+        } else if self.is_force_ignored(project_key, path)
+            || !settings.files.includes.is_included(path)

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.