fix(noDuplicateObjectKeys): correct grammatical error in JSON diagnostic message #7317
Conversation
WalkthroughThe PR fixes a user‑facing detail string in the per‑range diagnostic for the JSON rule suspicious/noDuplicateObjectKeys, changing "This where a duplicated key was declared again." to "This is where a duplicated key was declared again." No logic, control flow, data structures, or public APIs were changed. Assessment against linked issues
Suggested labels
Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (25)
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
crates/biome_json_analyze/src/lint/suspicious/no_duplicate_object_keys.rs (1)
86-86: Optional wording tweak: prefer “duplicate key” over “duplicated key”.Minor style polish for consistency and brevity.
Apply this diff if you agree:
- "This is where a duplicated key was declared again." + "This is where the duplicate key was declared again."
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
crates/biome_json_analyze/tests/specs/suspicious/noDuplicateObjectKeys/invalid.json.snapis excluded by!**/*.snapand included by**
📒 Files selected for processing (1)
crates/biome_json_analyze/src/lint/suspicious/no_duplicate_object_keys.rs(1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{rs,toml}
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Format Rust and TOML files before committing (use
just f/just format).
Files:
crates/biome_json_analyze/src/lint/suspicious/no_duplicate_object_keys.rs
crates/biome_*_{syntax,parser,formatter,analyze,factory,semantic}/**
📄 CodeRabbit inference engine (CLAUDE.md)
Maintain the per-language crate structure: biome_{lang}_{syntax,parser,formatter,analyze,factory,semantic}
Files:
crates/biome_json_analyze/src/lint/suspicious/no_duplicate_object_keys.rs
crates/biome_*/**
📄 CodeRabbit inference engine (CLAUDE.md)
Place core crates under /crates/biome_*/
Files:
crates/biome_json_analyze/src/lint/suspicious/no_duplicate_object_keys.rs
🧠 Learnings (1)
📚 Learning: 2025-08-11T11:46:05.836Z
Learnt from: CR
PR: biomejs/biome#0
File: crates/biome_diagnostics/CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:46:05.836Z
Learning: Applies to crates/biome_diagnostics/**/*.rs : Most diagnostic attributes may be specified only once (either on the type or a single field); #[advice] and #[verbose_advice] may appear multiple times and are recorded in declaration order
Applied to files:
crates/biome_json_analyze/src/lint/suspicious/no_duplicate_object_keys.rs
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (24)
- GitHub Check: Bench (biome_configuration)
- GitHub Check: Bench (biome_module_graph)
- GitHub Check: Bench (biome_package)
- GitHub Check: Bench (biome_graphql_formatter)
- GitHub Check: Bench (biome_json_analyze)
- GitHub Check: Bench (biome_html_formatter)
- GitHub Check: Bench (biome_css_analyze)
- GitHub Check: Bench (biome_graphql_parser)
- GitHub Check: Bench (biome_html_parser)
- GitHub Check: Bench (biome_json_parser)
- GitHub Check: Bench (biome_json_formatter)
- GitHub Check: Bench (biome_css_formatter)
- GitHub Check: Bench (biome_css_parser)
- GitHub Check: Bench (biome_js_analyze)
- GitHub Check: Bench (biome_js_parser)
- GitHub Check: Bench (biome_js_formatter)
- GitHub Check: Test Node.js API
- GitHub Check: autofix
- GitHub Check: Documentation
- GitHub Check: Test (depot-windows-2022-16)
- GitHub Check: Test (depot-ubuntu-24.04-arm-16)
- GitHub Check: Lint project (depot-ubuntu-24.04-arm-16)
- GitHub Check: Check Dependencies
- GitHub Check: Lint project (depot-windows-2022)
🔇 Additional comments (2)
crates/biome_json_analyze/src/lint/suspicious/no_duplicate_object_keys.rs (2)
86-86: Grammar fix LGTM.The insertion of “is” corrects the message and reads naturally. Thanks for tightening up a user‑facing string.
72-95: Phrase consistency confirmed
I ran a repo-wide search and only the “duplicated key” phrasing appears in this lint, with no instances of “duplicate key” elsewhere. No changes needed—feel free to keep the message as-is.
…tic message Fixed missing 'is' in the diagnostic message for the noDuplicateObjectKeys rule when applied to JSON files. The message now correctly reads 'This is where a duplicated key was declared again.' instead of 'This where a duplicated key was declared again.' Fixes biomejs#7307
f47ba07 to
673d5b2
Compare
CodSpeed Performance ReportMerging #7317 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
you can delete this file, I think this fix doesn't need changelog
|
|
@unvalley Ya ! removed the changeast file |
What this fixes
Fixed a grammar mistake in an error message. The message was missing the word "is".
Before (incorrect):
After (correct):
What changed
This makes the error message easier to read and understand for users.
Fixes #7307