chore: fix various typos across codebase #7216
Conversation
|
WalkthroughThis PR applies editorial spelling corrections across documentation, tests, and a Rust task. GOV governance text standardises “organisation” to “organization.” A CHANGELOG typo is corrected (JsLogicalExpreesion → JsLogicalExpression). Test descriptions fix “diagnotics” → “diagnostics” in two JS test files. A comment typo in a CSS grammar file is corrected (“insensitve” → “insensitive”). In Rust, a local variable is renamed from supression_reason to suppression_reason and passed accordingly. No logic, behaviour, or public API changes. Suggested labels
Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the "Integrations" page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
There was a problem hiding this comment.
Actionable comments posted: 1
🔭 Outside diff range comments (2)
xtask/rules_check/src/lib.rs (2)
510-516: Bug: Using JsonLanguage for CSS analysis
create_analyzer_options::<JsonLanguage>is used in the CSS branch. This will derive the wrong language settings and environment for CSS rules; diagnostics/options may be off or misapplied.Proposed fix:
- let options = create_analyzer_options::<JsonLanguage>( + let options = create_analyzer_options::<CssLanguage>( &workspace_settings, project_key, &file_path, test, );
556-562: Bug: Using JsonLanguage for GraphQL analysisSame issue here: GraphQL branch calls
create_analyzer_options::<JsonLanguage>. Should beGraphqlLanguage.Proposed fix:
- let options = create_analyzer_options::<JsonLanguage>( + let options = create_analyzer_options::<GraphqlLanguage>( &workspace_settings, project_key, &file_path, test, );
🧹 Nitpick comments (1)
GOVERNANCE.md (1)
78-78: Grammar polish: add article and improve flowReads more naturally and fixes the missing article before “Biome organization”.
-Core Contributors are outstanding [maintainers](#maintainer), are ambassadors of Biome organization and lead by example the community. +Core Contributors are outstanding [maintainers](#maintainer), act as ambassadors of the Biome organization, and lead the community by example.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
GOVERNANCE.md(2 hunks)packages/@biomejs/biome/CHANGELOG.md(1 hunks)packages/@biomejs/js-api/tests/lintContent.test.ts(3 hunks)packages/@biomejs/js-api/tests/nodejs.test.ts(1 hunks)xtask/codegen/css.ungram(1 hunks)xtask/rules_check/src/lib.rs(2 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
xtask/codegen/*.ungram
📄 CodeRabbit Inference Engine (CLAUDE.md)
xtask/codegen/*.ungram: Grammar definitions must be placed in/xtask/codegen/*.ungram
When adding new syntax nodes or rules, modify the appropriate.ungramfile inxtask/codegen/and runjust gen-allto regenerate code
Files:
xtask/codegen/css.ungram
**/*.{rs,toml}
📄 CodeRabbit Inference Engine (CLAUDE.md)
Format code (Rust + TOML) using
just formatFormat Rust and TOML files before committing (use
just f/just format).
Files:
xtask/rules_check/src/lib.rs
🪛 LanguageTool
GOVERNANCE.md
[style] ~42-~42: You can shorten this phrase to avoid wordiness.
Context: ...eration](#moderation). ### Lead Leads are the owners of the organization. Leads have additiona...
(BE_THE_MAKER_OF_WORDINESS)
[uncategorized] ~78-~78: Possible missing preposition found.
Context: ... Biome organization and lead by example the community. - Push access to the [Biome...
(AI_HYDRA_LEO_MISSING_IN)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
- GitHub Check: Test Node.js API
- GitHub Check: Documentation
- GitHub Check: Test (depot-ubuntu-24.04-arm-16)
- GitHub Check: Check JS Files
- GitHub Check: Test (depot-windows-2022-16)
- GitHub Check: End-to-end tests
- GitHub Check: Lint project (depot-windows-2022)
- GitHub Check: Lint project (depot-ubuntu-24.04-arm-16)
- GitHub Check: Check Dependencies
- GitHub Check: Parser conformance
- GitHub Check: autofix
🔇 Additional comments (6)
xtask/codegen/css.ungram (1)
1834-1834: Spelling fix looks goodNice catch on “insensitive”. No functional impact.
xtask/rules_check/src/lib.rs (2)
323-323: Rename to suppression_reason: ✅Good typo fix and clearer naming. No behaviour change.
332-339: Pass the renamed variable consistently: ✅The call site now passes
suppression_reasoncorrectly. All good.packages/@biomejs/js-api/tests/nodejs.test.ts (1)
26-26: Typo fix in test description: ✅“diagnostics” spelling corrected. Thanks!
packages/@biomejs/js-api/tests/lintContent.test.ts (1)
26-26: Consistent test wording: ✅All three descriptions now read “should emit diagnostics”. Small change, big readability win.
Also applies to: 46-46, 67-67
packages/@biomejs/biome/CHANGELOG.md (1)
3827-3831: Typo fix in CHANGELOG: ✅
JsLogicalExpressionnow spelled correctly. Matches the intent in the PR summary.
| ### Lead | ||
|
|
||
| Leads are the owners of the organisation. | ||
| Leads are the owners of the organization. |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Tidy phrasing: “Leads own the organization” reads cleaner
Minor wording polish; also aligns with the style hint about wordiness.
Apply this diff:
-Leads are the owners of the organization.
+Leads own the organization.Optionally verify there aren’t stray British spellings or the original typos elsewhere in the repo:
🏁 Script executed:
#!/bin/bash
# Find remaining British spellings where US English is intended
rg -n -S '\borganisation(s)?\b' || true
# Sanity check for the original test typo elsewhere
rg -n -S '\bdiagnotics\b' || trueLength of output: 766
Tidy phrasing & standardise spelling
Apply this diff in GOVERNANCE.md (line 42):
-Leads are the owners of the organization.
+Leads own the organization.We also spotted several instances of the British spelling “organisation” in tests, snapshots and docs—please consider bulk-replacing to US English (“organization”):
• crates/biome_js_formatter/tests/specs/prettier/js/destructuring/destructuring.js (lines 9, 16)
• crates/biome_js_formatter/tests/specs/prettier/js/destructuring/destructuring.js.prettier-snap (lines 11, 20)
• crates/biome_js_formatter/report-es2024+.md (lines 2675, 2684)
No “diagnotics” typos were found.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| Leads are the owners of the organization. | |
| Leads own the organization. |
🧰 Tools
🪛 LanguageTool
[style] ~42-~42: You can shorten this phrase to avoid wordiness.
Context: ...eration](#moderation). ### Lead Leads are the owners of the organization. Leads have additiona...
(BE_THE_MAKER_OF_WORDINESS)
🤖 Prompt for AI Agents
In GOVERNANCE.md around line 42 replace the sentence "Leads are the owners of
the organisation." with "Leads are the owners of the organization." to tidy
phrasing and standardize US spelling; additionally perform a bulk replace of
"organisation" → "organization" in the listed files and lines
(crates/biome_js_formatter/tests/specs/prettier/js/destructuring/destructuring.js
lines ~9,16;
crates/biome_js_formatter/tests/specs/prettier/js/destructuring/destructuring.js.prettier-snap
lines ~11,20; crates/biome_js_formatter/report-es2024+.md lines ~2675,2684),
commit each modified file with a concise message, and run tests/snap checks to
ensure nothing else broke.
Summary
Apply spelling corrections across the codebase
Chores: