-
-
Notifications
You must be signed in to change notification settings - Fork 720
chore: fix changesets #7202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix changesets #7202
Conversation
|
Name | Type |
---|---|
@biomejs/biome | Minor |
@biomejs/cli-win32-x64 | Minor |
@biomejs/cli-win32-arm64 | Minor |
@biomejs/cli-darwin-x64 | Minor |
@biomejs/cli-darwin-arm64 | Minor |
@biomejs/cli-linux-x64 | Minor |
@biomejs/cli-linux-arm64 | Minor |
@biomejs/cli-linux-x64-musl | Minor |
@biomejs/cli-linux-arm64-musl | Minor |
@biomejs/wasm-web | Minor |
@biomejs/wasm-bundler | Minor |
@biomejs/wasm-nodejs | Minor |
@biomejs/backend-jsonrpc | Patch |
@biomejs/js-api | Major |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
WalkthroughThis PR updates documentation formatting in three .changeset markdown files:
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.changeset/fancy-trains-happen.md (1)
13-13
: Fix minor grammar and keep example formatting consistent.Plural noun and single inline code span for the numeric example reads better.
-1. **`natural`**. Compares two strings using a natural ASCII order. Uppercase letters come first (e.g. `A < a < B < b`) and number are compared in a human way (e.g. `9` < `10`). This is the default value. +1. **`natural`**. Compares two strings using a natural ASCII order. Uppercase letters come first (e.g. `A < a < B < b`) and numbers are compared in a human way (e.g. `9 < 10`). This is the default value..changeset/thick-seas-draw.md (1)
5-5
: Typo: “compliment” → “complement”.We’re complementing existing support, not paying it a compliment. Couldn’t resist.
-Added support for tracking stable results in user-provided React hooks that return objects to [`useExhaustiveDependencies`](https://biomejs.dev/linter/rules/use-exhaustive-dependencies/) to compliment existing support for array return values. For example: +Added support for tracking stable results in user-provided React hooks that return objects to [`useExhaustiveDependencies`](https://biomejs.dev/linter/rules/use-exhaustive-dependencies/) to complement existing support for array return values. For example:
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.changeset/fancy-trains-happen.md
(1 hunks).changeset/mighty-seals-dance.md
(1 hunks).changeset/thick-seas-draw.md
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/*.md
📄 CodeRabbit Inference Engine (CONTRIBUTING.md)
.changeset/*.md
: Create changesets withjust new-changeset
; store them in.changeset/
with correct frontmatter (package keys and change type).
In changeset descriptions, follow content conventions: user-facing changes only; past tense for what you did; present tense for current behavior; link issues for fixes; link rules/assists; include representative code blocks; end every sentence with a period.
When adding headers in a changeset, only use #### or ##### levels.
Files:
.changeset/thick-seas-draw.md
.changeset/mighty-seals-dance.md
.changeset/fancy-trains-happen.md
🧠 Learnings (1)
📓 Common learnings
Learnt from: CR
PR: biomejs/biome#0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:40:38.070Z
Learning: Applies to .changeset/*.md : In changeset descriptions, follow content conventions: user-facing changes only; past tense for what you did; present tense for current behavior; link issues for fixes; link rules/assists; include representative code blocks; end every sentence with a period.
🔇 Additional comments (2)
.changeset/mighty-seals-dance.md (1)
9-9
: Good switch to json5 for a commented config snippet.This correctly allows the inline comment to be valid. LGTM.
.changeset/thick-seas-draw.md (1)
7-21
: json5 fence and file hint improve clarity; valid JSON5.Comment-before-object is fine in JSON5; the example reads clearly. LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did markdownlint flag these or was it the changeset cli?
It was the changeset CLI. It failed parsing some changeset https://github.com/biomejs/biome/actions/runs/16937968394/job/47999107743 |
Summary
The release workflow is failing. This PR fixes it
Test Plan
I run it locally and made sure it doesn't error
Docs
N/A