+
Skip to content

Conversation

ematipico
Copy link
Member

Summary

The release workflow is failing. This PR fixes it

Test Plan

I run it locally and made sure it doesn't error

Docs

N/A

Copy link

changeset-bot bot commented Aug 13, 2025

⚠️ No Changeset found

Latest commit: ffb9130

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 14 packages
Name Type
@biomejs/biome Minor
@biomejs/cli-win32-x64 Minor
@biomejs/cli-win32-arm64 Minor
@biomejs/cli-darwin-x64 Minor
@biomejs/cli-darwin-arm64 Minor
@biomejs/cli-linux-x64 Minor
@biomejs/cli-linux-arm64 Minor
@biomejs/cli-linux-x64-musl Minor
@biomejs/cli-linux-arm64-musl Minor
@biomejs/wasm-web Minor
@biomejs/wasm-bundler Minor
@biomejs/wasm-nodejs Minor
@biomejs/backend-jsonrpc Patch
@biomejs/js-api Major

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Aug 13, 2025

Walkthrough

This PR updates documentation formatting in three .changeset markdown files:

  • fancy-trains-happen.md: consolidates multiple inline code spans into one (“A < a < B < b”).
  • mighty-seals-dance.md: changes code fence language from json to json5 for a config example; content unchanged.
  • thick-seas-draw.md: switches an example from json to json5 and adds a top-level “// biome.json” comment; data unchanged.
    There are no semantic changes, no behavioural modifications, and no public API signature changes.
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/fix-changesets

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
.changeset/fancy-trains-happen.md (1)

13-13: Fix minor grammar and keep example formatting consistent.

Plural noun and single inline code span for the numeric example reads better.

-1. **`natural`**. Compares two strings using a natural ASCII order. Uppercase letters come first (e.g. `A < a < B < b`) and number are compared in a human way (e.g. `9` < `10`). This is the default value.
+1. **`natural`**. Compares two strings using a natural ASCII order. Uppercase letters come first (e.g. `A < a < B < b`) and numbers are compared in a human way (e.g. `9 < 10`). This is the default value.
.changeset/thick-seas-draw.md (1)

5-5: Typo: “compliment” → “complement”.

We’re complementing existing support, not paying it a compliment. Couldn’t resist.

-Added support for tracking stable results in user-provided React hooks that return objects to [`useExhaustiveDependencies`](https://biomejs.dev/linter/rules/use-exhaustive-dependencies/) to compliment existing support for array return values. For example:
+Added support for tracking stable results in user-provided React hooks that return objects to [`useExhaustiveDependencies`](https://biomejs.dev/linter/rules/use-exhaustive-dependencies/) to complement existing support for array return values. For example:
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a3840ac and ffb9130.

📒 Files selected for processing (3)
  • .changeset/fancy-trains-happen.md (1 hunks)
  • .changeset/mighty-seals-dance.md (1 hunks)
  • .changeset/thick-seas-draw.md (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
.changeset/*.md

📄 CodeRabbit Inference Engine (CONTRIBUTING.md)

.changeset/*.md: Create changesets with just new-changeset; store them in .changeset/ with correct frontmatter (package keys and change type).
In changeset descriptions, follow content conventions: user-facing changes only; past tense for what you did; present tense for current behavior; link issues for fixes; link rules/assists; include representative code blocks; end every sentence with a period.
When adding headers in a changeset, only use #### or ##### levels.

Files:

  • .changeset/thick-seas-draw.md
  • .changeset/mighty-seals-dance.md
  • .changeset/fancy-trains-happen.md
🧠 Learnings (1)
📓 Common learnings
Learnt from: CR
PR: biomejs/biome#0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:40:38.070Z
Learning: Applies to .changeset/*.md : In changeset descriptions, follow content conventions: user-facing changes only; past tense for what you did; present tense for current behavior; link issues for fixes; link rules/assists; include representative code blocks; end every sentence with a period.
🔇 Additional comments (2)
.changeset/mighty-seals-dance.md (1)

9-9: Good switch to json5 for a commented config snippet.

This correctly allows the inline comment to be valid. LGTM.

.changeset/thick-seas-draw.md (1)

7-21: json5 fence and file hint improve clarity; valid JSON5.

Comment-before-object is fine in JSON5; the example reads clearly. LGTM.

Copy link
Contributor

@dyc3 dyc3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did markdownlint flag these or was it the changeset cli?

@ematipico
Copy link
Member Author

ematipico commented Aug 13, 2025

Did markdownlint flag these or was it the changeset cli?

It was the changeset CLI. It failed parsing some changeset https://github.com/biomejs/biome/actions/runs/16937968394/job/47999107743

@ematipico ematipico merged commit 232aaeb into main Aug 13, 2025
4 checks passed
@ematipico ematipico deleted the chore/fix-changesets branch August 13, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载