crates/biome_js_analyze/src/lint/style/use_for_of.rs (2)

19-28: Tighten wording to match actual rule behaviour; minor phrasing nits

The implementation doesn’t distinguish reads vs writes to array elements; array[i] used as an lvalue still triggers the rule. The docs currently say “solely used to read”, which can mislead. Also, “within the outer scope” reads oddly, and “Array.entries()” should be “Array.prototype.entries()”. Trim incidental trailing spaces too.

Proposed wording tweaks:

-    /// This rule recommends using a `for...of` loop in place of a `for` loop 
-    /// when the loop index is solely used to read from the iterated array.
+    /// This rule recommends using a `for...of` loop instead of a `for` loop
+    /// when the loop index is only used to index into the same array referenced in the loop condition.
@@
-    /// ### Exceptions for Index Usage
-    /// When the loop index is declared within the outer scope or used anywhere within the loop body,
-    /// it is acceptable to use a `for` loop.
-    /// (`Array.entries()` can be used to a similar effect.)
+    /// ### Exceptions for index usage
+    /// When the loop index is declared outside the loop (in an outer scope) or used anywhere within the loop body,
+    /// it is acceptable to use a `for` loop.
+    /// (Alternatively, `Array.prototype.entries()` can be used to obtain both index and value.)

Optional: the diagnostic message elsewhere says “for-of” (hyphen) while the docs say “for...of”. Consider unifying the terminology in a follow-up.

Also, as this is Rustdoc in-source (per project guidelines), no changeset should be needed; please confirm with maintainers. And don’t forget to run just format before merging.

---

48-52: Clarify the inline comment in the valid example

Make it explicit why this for-loop is acceptable.

-    ///    // `i` is used, so for loop is OK
+    ///    // `i` is also used directly (not just for indexing), so a `for` loop is acceptable

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

Learnt from: CR
PR: biomejs/biome#0
File: CONTRIBUTING.md:0-0
Timestamp: 2025-08-11T11:40:38.097Z
Learning: For documentation of rules/assists/options, use inline Rustdoc in source code; other docs updates should go to the website repo’s next branch.