chore: fix typos in biome css analyze crates #7187

JamBalaya56562 · 2025-08-11T12:21:06Z

Summary

Fix typos in biome_css_analyze tests and CSS fixtures

Tests:

Correct test function name typos from 'kown' to 'known' in several KNOWN_* properties order tests
Change sumsung to samsung
Fix typo in CSS test fixtures by replacing 'opactity' with 'opacity' in valid and invalid sortedProperties cases

Test Plan

cargo test

changeset-bot · 2025-08-11T12:21:10Z

⚠️ No Changeset found

Latest commit: 78d20fd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-08-11T12:21:13Z

Walkthrough

Renamed six Rust test functions from test_kown_properties_order to test_known_properties_order across edge, explorer, firefox, safari, samsung internet, and US browser property groups. Test bodies unchanged. In CSS test fixtures, corrected opactity to opacity in both invalid.css and valid.css for the .example-from-doc-comment rule. Added a trailing newline to valid.css. No changes to underlying data or public APIs.

Suggested labels

A-Project

Suggested reviewers

siketyan
ematipico

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

crates/biome_css_analyze/src/keywords.rs (1)
5949-5953: Optional consistency: align naming and style with other “sorted” tests

Most tests here use is_sorted or compare against a sorted copy; these six use windows(2). Both are fine, but consider renaming to ..._sorted and using the same style for consistency.

Example tweak:
-#[test]
-fn test_known_edge_properties_order() {
-    for items in KNOWN_EDGE_PROPERTIES.windows(2) {
-        assert!(items[0] < items[1], "{} < {}", items[0], items[1]);
-    }
-}
+#[test]
+fn test_known_edge_properties_sorted() {
+    let sorted = KNOWN_EDGE_PROPERTIES.to_vec();
+    let _ = sorted.is_sorted();
+    assert_eq!(KNOWN_EDGE_PROPERTIES, sorted.as_slice());
+}

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a829f24 and 78d20fd.

⛔ Files ignored due to path filters (2)

crates/biome_css_analyze/tests/specs/source/useSortedProperties/invalid.css.snap is excluded by !**/*.snap and included by **
crates/biome_css_analyze/tests/specs/source/useSortedProperties/valid.css.snap is excluded by !**/*.snap and included by **

📒 Files selected for processing (3)

crates/biome_css_analyze/src/keywords.rs (1 hunks)
crates/biome_css_analyze/tests/specs/source/useSortedProperties/invalid.css (1 hunks)
crates/biome_css_analyze/tests/specs/source/useSortedProperties/valid.css (2 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

crates/biome_*/**/*

📄 CodeRabbit Inference Engine (CLAUDE.md)

Core crates must be located in /crates/biome_*/

Files:

crates/biome_css_analyze/tests/specs/source/useSortedProperties/valid.css
crates/biome_css_analyze/src/keywords.rs
crates/biome_css_analyze/tests/specs/source/useSortedProperties/invalid.css

**/*.{rs,toml}

📄 CodeRabbit Inference Engine (CLAUDE.md)

Format code (Rust + TOML) using just format

Format Rust and TOML files before committing (use just f/just format).

Files:

crates/biome_css_analyze/src/keywords.rs

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (24)

GitHub Check: Documentation
GitHub Check: Lint project (depot-ubuntu-24.04-arm-16)
GitHub Check: Check Dependencies
GitHub Check: Test (depot-windows-2022-16)
GitHub Check: Lint project (depot-windows-2022)
GitHub Check: Test (depot-ubuntu-24.04-arm-16)
GitHub Check: Test Node.js API
GitHub Check: Bench (biome_html_formatter)
GitHub Check: Bench (biome_graphql_formatter)
GitHub Check: Bench (biome_module_graph)
GitHub Check: Bench (biome_configuration)
GitHub Check: Bench (biome_package)
GitHub Check: Bench (biome_css_parser)
GitHub Check: Bench (biome_json_formatter)
GitHub Check: Bench (biome_graphql_parser)
GitHub Check: Bench (biome_json_analyze)
GitHub Check: Bench (biome_html_parser)
GitHub Check: Bench (biome_js_analyze)
GitHub Check: Bench (biome_js_parser)
GitHub Check: Bench (biome_css_analyze)
GitHub Check: Bench (biome_css_formatter)
GitHub Check: Bench (biome_json_parser)
GitHub Check: autofix
GitHub Check: Bench (biome_js_formatter)

🔇 Additional comments (4)

crates/biome_css_analyze/tests/specs/source/useSortedProperties/invalid.css (1)

72-72: Typo fix looks spot on

Good catch switching opactity to opacity; keeps the fixture meaningful without changing test intent.

crates/biome_css_analyze/tests/specs/source/useSortedProperties/valid.css (2)

79-79: Corrected 'opacity' in transition

Nice one. This keeps the “valid” example actually valid and aligned with the docs.

106-106: Trailing newline added

Tiny but tidy. This keeps editors and linters happy.

crates/biome_css_analyze/src/keywords.rs (1)

5949-5949: Renaming tests kown -> known: LGTM

Thanks for the polish. Names now read cleanly; no behavioural change to the assertions.

Also applies to: 5956-5956, 5963-5963, 5970-5970, 5977-5977, 5984-5984

codspeed-hq · 2025-08-11T12:35:42Z

CodSpeed Performance Report

Merging #7187 will not alter performance

_{Comparing JamBalaya56562:css-analyze-typos (78d20fd) with main (9ab31db)¹}

Summary

✅ 128 untouched benchmarks

No successful run was found on main (a829f24) during the generation of this report, so 9ab31db was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

github-actions bot added A-Linter Area: linter L-CSS Language: CSS labels Aug 11, 2025

chore: fix typos in biome css analyze crates

78d20fd

JamBalaya56562 force-pushed the css-analyze-typos branch from 8df3b60 to 78d20fd Compare August 11, 2025 12:22

coderabbitai bot reviewed Aug 11, 2025

View reviewed changes

siketyan approved these changes Aug 11, 2025

View reviewed changes

siketyan merged commit 4244a73 into biomejs:main Aug 11, 2025
30 checks passed

JamBalaya56562 deleted the css-analyze-typos branch August 11, 2025 13:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

chore: fix typos in biome css analyze crates #7187

chore: fix typos in biome css analyze crates #7187

Uh oh!

JamBalaya56562 commented Aug 11, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Aug 11, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Aug 11, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

codspeed-hq bot commented Aug 11, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

chore: fix typos in biome css analyze crates #7187

chore: fix typos in biome css analyze crates #7187

Uh oh!

Conversation

JamBalaya56562 commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Uh oh!

changeset-bot bot commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Suggested labels

Suggested reviewers

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

codspeed-hq bot commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #7187 will not alter performance

Summary

Footnotes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

JamBalaya56562 commented Aug 11, 2025 •

edited

Loading

changeset-bot bot commented Aug 11, 2025 •

edited

Loading

coderabbitai bot commented Aug 11, 2025 •

edited

Loading

codspeed-hq bot commented Aug 11, 2025 •

edited

Loading